feat: delete orphan workflows during sync — preserve custom-* prefix #315

Merged

jmiller merged 4 commits from feature/delete-orphan-workflows into main 2026-06-23 21:49:40 +00:00

Conversation 0 Commits 4 Files Changed 37

+165 -41

jmiller commented 2026-06-23 18:31:45 +00:00

Owner

Copy Link

Copy Source

Summary

workflow_sync.php --delete-orphans now removes workflows from repos that are not in the platform template.

Protected from deletion:

• Workflows matching template names (synced normally)
• Workflows with custom- prefix (repo-specific convention)
• The custom/ subdirectory (future: subfolder discovery, see #314)

New methods:

• deleteOrphanWorkflows() — compares repo workflows against template, deletes extras
• deleteFile() — deletes a file via Gitea Contents API
• listWorkflowEntries() — lists all entries (files + dirs) in workflows dir

Test plan

• php -l cli/workflow_sync.php passes
• --delete-orphans with --dry-run shows WOULD DELETE for non-template workflows
• custom-*.yml files are preserved (shown as KEPT)
• Template workflows are not deleted
• Summary line includes deleted count

## Summary `workflow_sync.php --delete-orphans` now removes workflows from repos that are not in the platform template. **Protected from deletion:** - Workflows matching template names (synced normally) - Workflows with `custom-` prefix (repo-specific convention) - The `custom/` subdirectory (future: subfolder discovery, see #314) **New methods:** - `deleteOrphanWorkflows()` — compares repo workflows against template, deletes extras - `deleteFile()` — deletes a file via Gitea Contents API - `listWorkflowEntries()` — lists all entries (files + dirs) in workflows dir ## Test plan - [ ] `php -l cli/workflow_sync.php` passes - [ ] `--delete-orphans` with `--dry-run` shows WOULD DELETE for non-template workflows - [ ] `custom-*.yml` files are preserved (shown as KEPT) - [ ] Template workflows are not deleted - [ ] Summary line includes deleted count

jmiller added 1 commit 2026-06-23 18:31:45 +00:00

feat: delete orphan workflows during sync — preserve custom-* prefix ... 8cea26d748

workflow_sync.php --delete-orphans now removes workflows from repos that
are not in the platform template. Protected from deletion:
- Workflows matching template names (synced normally)
- Workflows with custom- prefix (repo-specific convention)
- The custom/ subdirectory (future: subfolder discovery)

jmiller added 1 commit 2026-06-23 18:34:41 +00:00

chore(version): auto-bump patch 09.38.01-dev [skip ci] bb24a58903

jmiller added 1 commit 2026-06-23 19:13:45 +00:00

fix: address review findings in workflow_sync.php ... 2d856c8846

- Fix #1: protect PLATFORM_EXCLUDES workflows from orphan deletion
- Fix #2: remove dead CUSTOM_DIR constant and listWorkflowEntries()
- Fix #3: fix pre-existing undefined $label bug on EXCLUDED branch

jmiller added 1 commit 2026-06-23 19:14:13 +00:00

chore(version): auto-bump patch 09.38.02-dev [skip ci] 5a918e2d1f

jmiller merged commit 4e3e9b7899 into main 2026-06-23 21:49:40 +00:00

jmiller deleted branch feature/delete-orphan-workflows 2026-06-23 21:49:42 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

build

Build system changes

ci-cd

CI/CD pipeline changes

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

php

PHP code changes

push-failure

File push failure requiring attention

python

Python code changes

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#315