MokoConsulting/MokoCLI
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Packages Releases 8 Wiki Activity

feat: nested Joomla package support in release_package.php #323

Merged
jmiller merged 2 commits from fix/release-dead-variable into main 2026-06-27 02:17:32 +00:00
Conversation 0 Commits 2 Files Changed 1
+79 -1
jmiller commented 2026-06-27 02:12:12 +00:00
Owner
Copy Link
Copy Source

Summary\n\n- Detect git submodules that are themselves Joomla packages (contain pkg_*.xml + packages/ dir)\n- Recursively build each sub-extension into individual ZIPs, assemble the outer package\n- Manifest filtering ensures only declared sub-extensions are included\n- ZIP collision prevention via isolated output subdirectories\n- Exclude patterns applied consistently to nested top-level files\n- Auto-patch folder=\"packages\" in nested manifests\n- Include all top-level directories (not just language/) in nested packages\n- Remove dead $cleanupFile variable in release.php\n\n## Test plan\n\n- [ ] Build a Joomla package that contains a nested package submodule\n- [ ] Verify nested sub-extension ZIPs are correctly assembled inside the nested package ZIP\n- [ ] Verify no filename collisions when outer and nested packages share sub-extension names\n- [ ] Verify exclude patterns filter unwanted files from nested packages

## Summary\n\n- Detect git submodules that are themselves Joomla packages (contain `pkg_*.xml` + `packages/` dir)\n- Recursively build each sub-extension into individual ZIPs, assemble the outer package\n- Manifest filtering ensures only declared sub-extensions are included\n- ZIP collision prevention via isolated output subdirectories\n- Exclude patterns applied consistently to nested top-level files\n- Auto-patch `folder=\"packages\"` in nested manifests\n- Include all top-level directories (not just language/) in nested packages\n- Remove dead `$cleanupFile` variable in release.php\n\n## Test plan\n\n- [ ] Build a Joomla package that contains a nested package submodule\n- [ ] Verify nested sub-extension ZIPs are correctly assembled inside the nested package ZIP\n- [ ] Verify no filename collisions when outer and nested packages share sub-extension names\n- [ ] Verify exclude patterns filter unwanted files from nested packages
jmiller added 2 commits 2026-06-27 02:12:12 +00:00
feat: support nested Joomla packages in release_package.php
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 9s
Details
8e30fa54b3 
When a sub-package directory contains its own pkg_*.xml manifest and
packages/ directory (e.g. a git submodule), recursively build each
sub-extension into ZIPs before assembling the outer package ZIP.
fix: harden nested package build against collisions and missing assets
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 10s
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 6s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Details
Platform: mokocli CI / Gate 1: Code Quality (pull_request) Failing after 53s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Successful in 15s
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Failing after 2m32s
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.1) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.2) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.3) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 3: Self-Health Check (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 4: Governance (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 5: Template Integrity (pull_request) Has been cancelled
Details
Platform: mokocli CI / CI Summary (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report Issues (pull_request) Has been cancelled
Details
3c420284e3 
- Write nested sub-extension ZIPs to subdirectory to prevent filename
  collisions with outer package ZIPs (deferred ZipArchive::addFile reads)
- Apply exclude patterns to nested top-level files (parity with outer)
- Patch nested manifest with folder="packages" so Joomla finds sub-ZIPs
- Include all top-level directories (not just language/) in nested packages

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG
jmiller merged commit a6c4fe0688 into main 2026-06-27 02:17:32 +00:00
jmiller deleted branch fix/release-dead-variable 2026-06-27 02:17:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#323
Delete Branch "fix/release-dead-variable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?