feat(cli): add theme_vars_check.php for client MokoOnyx themes #327

Merged

jmiller merged 2 commits from feat/theme-vars-check into main 2026-06-29 16:45:43 +00:00

Conversation 0 Commits 2 Files Changed 1

+191

jmiller commented 2026-06-29 16:36:41 +00:00

Owner

Copy Link

Copy Source

Adds cli/theme_vars_check.php — validation for client MokoOnyx theme packages, the logic behind the new Template-Client Theme Variables Check workflow.

Checks:

• Required CSS variables defined in both light.custom.css and dark.custom.css (33 tokens: accent + Bootstrap contextual colors, -rgb, -text-emphasis, -bg-subtle, body, links).
• Required files present (templateDetails.xml, light/dark custom CSS, user.css).
• Manifest sanity: <version> set, update server is the dynamic MokoGitea feed (not a legacy /raw/branch/ URL), and <dlid> present.

Standalone script (plain PHP + getopt, no CliFramework/SourceResolver dependency) so it runs even while the shared framework autoloader is broken. Tested green against a real client repo and red against a repo with missing vars / legacy URL / no dlid.

Authored-by: Moko Consulting

Adds `cli/theme_vars_check.php` — validation for client MokoOnyx theme packages, the logic behind the new Template-Client `Theme Variables Check` workflow. Checks: - **Required CSS variables** defined in **both** `light.custom.css` and `dark.custom.css` (33 tokens: accent + Bootstrap contextual colors, `-rgb`, `-text-emphasis`, `-bg-subtle`, body, links). - **Required files** present (`templateDetails.xml`, light/dark custom CSS, `user.css`). - **Manifest sanity**: `<version>` set, update server is the dynamic MokoGitea feed (not a legacy `/raw/branch/` URL), and `<dlid>` present. Standalone script (plain PHP + `getopt`, no `CliFramework`/`SourceResolver` dependency) so it runs even while the shared framework autoloader is broken. Tested green against a real client repo and red against a repo with missing vars / legacy URL / no dlid. Authored-by: Moko Consulting

jmiller added 1 commit 2026-06-29 16:36:41 +00:00

feat(cli): add theme_vars_check.php for client MokoOnyx themes ... 7e4d88eea5

Validates a client theme package: required CSS variables defined in both
light.custom.css and dark.custom.css, required files present, and
templateDetails.xml sanity (version, dynamic update server not raw/branch,
dlid). Standalone (no CliFramework dependency).

Authored-by: Moko Consulting

jmiller added 1 commit 2026-06-29 16:45:15 +00:00

feat(cli): derive required vars from MokoOnyx standard theme + repo metadata ... b1f2c391cb

- Read the required CSS variable set dynamically from the MokoOnyx standard
  theme (--reference checkout) instead of a hardcoded list, so it auto-syncs.
  Verifies client light/dark custom CSS defines every standard variable.
- Add optional repo-metadata check via Gitea API (--api-base/--repo/--token):
  description, website, topics, default branch.
- Drop unused --strict flag.

Authored-by: Moko Consulting

jmiller merged commit 97f2226288 into main 2026-06-29 16:45:43 +00:00

jmiller deleted branch feat/theme-vars-check 2026-06-29 16:45:43 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

build

Build system changes

ci-cd

CI/CD pipeline changes

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

php

PHP code changes

push-failure

File push failure requiring attention

python

Python code changes

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#327