MokoConsulting/MokoCLI
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests 1 Packages Releases 8 Wiki Activity

feat(cli): theme_vars_check manifest completeness + fileset integrity #328

Merged
jmiller merged 1 commits from feat/theme-vars-manifest into main 2026-06-29 16:58:09 +00:00
Conversation 0 Commits 1 Files Changed 1
+39
jmiller commented 2026-06-29 16:57:52 +00:00
Owner
Copy Link
Copy Source

Extends theme_vars_check.php manifest validation:

  • Required fields: <name>, <element>, <author>, <creationDate>.
  • <scriptfile> target exists in src/.
  • Fileset integrity — every <filename>/<folder> in <fileset> exists in src/. This catches the "Failed to find source folder" install-failure class at CI time (the exact bug from the missing js/user.js + banners).

No workflow change needed — same invocation. Tested green against a real client repo; red against a repo with a missing script.php and a bogus fileset entry.

Authored-by: Moko Consulting

Extends `theme_vars_check.php` manifest validation: - **Required fields**: `<name>`, `<element>`, `<author>`, `<creationDate>`. - **`<scriptfile>`** target exists in `src/`. - **Fileset integrity** — every `<filename>`/`<folder>` in `<fileset>` exists in `src/`. This catches the *"Failed to find source folder"* install-failure class at CI time (the exact bug from the missing `js/user.js` + `banners`). No workflow change needed — same invocation. Tested green against a real client repo; red against a repo with a missing `script.php` and a bogus fileset entry. Authored-by: Moko Consulting
jmiller added 1 commit 2026-06-29 16:57:52 +00:00
feat(cli): theme_vars_check manifest completeness + fileset integrity
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Failing after 4s
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Failing after 2s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 10s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 21s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 30s
Details
Platform: mokocli CI / Gate 1: Code Quality (pull_request) Failing after 1m12s
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Successful in 4m36s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.1) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.2) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.3) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 3: Self-Health Check (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 4: Governance (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 5: Template Integrity (pull_request) Has been cancelled
Details
Platform: mokocli CI / CI Summary (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
5846ccc3e8 
- Verify required manifest fields: <name>, <element>, <author>, <creationDate>.
- Verify <scriptfile> target exists in src/.
- Fileset integrity: every <filename>/<folder> in <fileset> must exist in src/
  — catches the "Failed to find source folder" install failure class at CI time.

Authored-by: Moko Consulting
jmiller merged commit c57a7e4b96 into main 2026-06-29 16:58:09 +00:00
jmiller deleted branch feat/theme-vars-manifest 2026-06-29 16:58:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#328
Delete Branch "feat/theme-vars-manifest"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?