fix: pr-check platform detection via metadata API, allow fix/patch to main #331

Merged

jmiller merged 2 commits from hotfix/pr-check-metadata-platform into main 2026-07-04 19:36:04 +00:00

Conversation 0 Commits 2 Files Changed 9

+21 -16

jmiller commented 2026-07-04 19:19:32 +00:00

Owner

Copy Link

Copy Source

Why

This is the upstream fix for the platform template so the changes made directly in MokoGitea-Fork#724 aren't reverted on the next workflow sync. .mokogitea/workflows/pr-check.yml here is the source that gets pushed to all org repos.

Changes

1. Platform detection no longer reads .mokogitea/manifest.xml.
manifest.xml is no longer used — platform now comes from the MokoGitea metadata API (GET /api/v1/repos/{owner}/{repo}/metadata → .platform, a public endpoint). The old PLATFORM=$(sed ... manifest.xml) aborted the Validate PR job under set -e on any repo without the file (e.g. generic Go/TS repos). New step:

API="${GITHUB_SERVER_URL:-https://git.mokoconsulting.tech}/api/v1/repos/${GITHUB_REPOSITORY}/metadata"
PLATFORM="$(curl -sf "$API" 2>/dev/null | python3 -c "import sys, json; print(json.load(sys.stdin).get('platform') or '')" 2>/dev/null || true)"
[ -z "$PLATFORM" ] && PLATFORM="generic"

Joomla/dolibarr detection is preserved (metadata returns joomla/dolibarr); generic repos fall back to generic.

2. Branch policy allows fix/* → main and patch/* → main.
The policy had drifted to fix/* → dev only, rejecting fix/patch PRs to main despite the documented policy. Now:

• fix/* → dev or main
• patch/* → dev, rc, or main

Notes

• Verified: metadata API returns "platform": "go" for MokoGitea-Fork; YAML parses clean.
• After merge, run workflow sync to propagate to all repos (the fork's local copy will be replaced by this version).

## Why This is the upstream fix for the platform template so the changes made directly in `MokoGitea-Fork#724` aren't reverted on the next workflow sync. `.mokogitea/workflows/pr-check.yml` here is the source that gets pushed to all org repos. ## Changes **1. Platform detection no longer reads `.mokogitea/manifest.xml`.** `manifest.xml` is no longer used — platform now comes from the MokoGitea **metadata API** (`GET /api/v1/repos/{owner}/{repo}/metadata` → `.platform`, a public endpoint). The old `PLATFORM=$(sed ... manifest.xml)` aborted the Validate PR job under `set -e` on any repo without the file (e.g. generic Go/TS repos). New step: ```bash API="${GITHUB_SERVER_URL:-https://git.mokoconsulting.tech}/api/v1/repos/${GITHUB_REPOSITORY}/metadata" PLATFORM="$(curl -sf "$API" 2>/dev/null | python3 -c "import sys, json; print(json.load(sys.stdin).get('platform') or '')" 2>/dev/null || true)" [ -z "$PLATFORM" ] && PLATFORM="generic" ``` Joomla/dolibarr detection is preserved (metadata returns `joomla`/`dolibarr`); generic repos fall back to `generic`. **2. Branch policy allows `fix/*` → `main` and `patch/*` → `main`.** The policy had drifted to `fix/* → dev` only, rejecting fix/patch PRs to main despite the documented policy. Now: - `fix/*` → `dev` or `main` - `patch/*` → `dev`, `rc`, or `main` ## Notes - Verified: metadata API returns `"platform": "go"` for MokoGitea-Fork; YAML parses clean. - After merge, run workflow sync to propagate to all repos (the fork's local copy will be replaced by this version).

jmiller added 1 commit 2026-07-04 19:19:32 +00:00

fix: pr-check platform detection via metadata API, allow fix/patch to main ... 9036d20898

Read the build platform from the MokoGitea metadata API instead of .mokogitea/manifest.xml, which is no longer used and caused the Detect platform step to abort under set -e when absent. Also allow fix/* and patch/* branches to target main per documented branch policy.

jmiller added 1 commit 2026-07-04 19:32:26 +00:00

fix: drop removed automation/ dir refs and dangling mcp submodule gitlinks ... 3f956f5661

The automation/ directory was removed (bulk_sync.php moved to wrappers/, others deleted) but references remained, hard-failing Gate 1 phpcs and the post-merge sync. Drop automation/ from phpcs/phpstan config and repoint sync-on-merge to wrappers/bulk_sync.php. Also remove the dangling mcp/servers/mokogitea_api and mcp/servers/windows/mcp_windows gitlinks that had no .gitmodules entry and broke submodule init at checkout.

jmiller merged commit bba1cbc845 into main 2026-07-04 19:36:04 +00:00

jmiller deleted branch hotfix/pr-check-metadata-platform 2026-07-04 19:36:05 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

automation

Automated processes or scripts

breaking-change

Breaking API or functionality change

build

Build system changes

ci-cd

CI/CD pipeline changes

config

Configuration file changes

css

CSS/styling changes

dependencies

Dependency updates

deploy-failure

Automated deploy failure tracking

docker

Docker configuration changes

documentation

Documentation changes

dolibarr

Dolibarr module or extension

generic

Generic project or library

good first issue

Good for newcomers

health-check

Repository health check results

health: excellent

Health score 90-100

health: fair

Health score 50-69

health: good

Health score 70-89

health: poor

Health score below 50

help wanted

Extra attention needed

html

HTML template changes

javascript

JavaScript code changes

joomla

Joomla extension or component

mokostandards

MokoStandards compliance

needs-review

Awaiting code review

php

PHP code changes

push-failure

File push failure requiring attention

python

Python code changes

security

Security-related changes

size/l

Large change (101-300 lines)

size/m

Medium change (31-100 lines)

size/s

Small change (11-30 lines)

size/xl

Extra large change (301-1000 lines)

size/xs

Extra small change (1-10 lines)

size/xxl

Extremely large change (1000+ lines)

standards-drift

Repository drifted from MokoStandards

standards-update

MokoStandards sync update

sync-failure

Bulk sync failure requiring attention

sync-report

Bulk sync run report

template-validation-failure

Template workflow validation failure

tests

Test suite changes

type: bug

Something isn't working

type: chore

Maintenance tasks

type: enhancement

Enhancement to existing feature

type: feature

New feature or request

type: refactor

Code refactoring

type: version

Version-related change

typescript

TypeScript code changes

version

Version bump or release

version-drift

Version mismatch detected

work-in-progress

Work in progress, not ready for merge

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#331