MokoConsulting/MokoCLI
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests 1 Packages Releases 8 Wiki Activity

fix: stale .mokogitea/workflows refs in scaffolding cause .mokogit/.mokogit nesting #352

New Issue
Closed
opened 2026-07-16 18:59:24 +00:00 by jmiller · 2 comments
jmiller commented 2026-07-16 18:59:24 +00:00
Owner
Copy Link
Copy Source

Summary

Half-migrated .mokogitea -> .mokogit references in the shared CLI scaffolding are the root cause of the .mokogit/.mokogit/ nested-directory bug observed across repos during the MokoGitea -> MokoGIT rebrand.

workflow_sync.php was migrated (it writes to .mokogit/workflows/ by basename, correctly), and the template repos (Template-Generic, Template-Joomla) are clean/flat. But other tools still scaffold/look-up the OLD .mokogitea/workflows/ path. When a repo is scaffolded with .mokogitea/ while workflow_sync writes the migrated .mokogit/, a later directory rename collides (mv .mokogitea .mokogit into an existing .mokogit) and produces .mokogit/.mokogit/.

Stale .mokogitea/workflows/ references to fix (nesting-relevant)

  • cli/repo_wizard.php:159 — scaffolds .mokogitea/workflows/pr-check.yml
  • cli/release.php:40-41 — looks for .mokogitea/workflows/bulk-repo-sync.yml
  • cli/bulk_workflow_push.php:39,73 — default dest .mokogitea/workflows/<filename>

Change these to .mokogit/workflows/ to match the template source-of-truth and workflow_sync.php.

Out of scope for this issue (separate concern)

~30 .mokogitea/manifest.xml references across the version/release scripts (version_read.php, version_bump.php, version_check.php, version_set_platform.php, version_auto_bump.php, release_create.php, release_package.php, release_validate.php, version_reset_dev.php, manifest_element.php, manifest_licensing.php, deploy_joomla.php, create_repo.php). That's the repo metadata manifest (now API-managed / deleted per the fork workflow), a different migration than the workflows dir. Do NOT lump it in here — changing the manifest path blindly risks breaking version/release reads across all repos.

Verification done

  • MokoSuiteBackup dev/main: no nested .mokogit/.mokogit/.
  • Template-Generic / Template-Joomla .mokogit/: clean, flat.
  • workflow_sync.php Phase 1/2 use $workflow['name'] (basename) + WORKFLOW_DIR = '.mokogit/workflows' -> cannot nest.

Reported from a MokoSuiteBackup session; filed here since the fix belongs in the shared tooling.

## Summary Half-migrated `.mokogitea` -> `.mokogit` references in the shared CLI scaffolding are the root cause of the `.mokogit/.mokogit/` **nested-directory bug** observed across repos during the MokoGitea -> MokoGIT rebrand. `workflow_sync.php` was migrated (it writes to `.mokogit/workflows/` by basename, correctly), and the template repos (Template-Generic, Template-Joomla) are clean/flat. But other tools still scaffold/look-up the OLD `.mokogitea/workflows/` path. When a repo is scaffolded with `.mokogitea/` while `workflow_sync` writes the migrated `.mokogit/`, a later directory rename collides (`mv .mokogitea .mokogit` into an existing `.mokogit`) and produces `.mokogit/.mokogit/`. ## Stale `.mokogitea/workflows/` references to fix (nesting-relevant) - `cli/repo_wizard.php:159` — scaffolds `.mokogitea/workflows/pr-check.yml` - `cli/release.php:40-41` — looks for `.mokogitea/workflows/bulk-repo-sync.yml` - `cli/bulk_workflow_push.php:39,73` — default dest `.mokogitea/workflows/<filename>` Change these to `.mokogit/workflows/` to match the template source-of-truth and `workflow_sync.php`. ## Out of scope for this issue (separate concern) ~30 `.mokogitea/manifest.xml` references across the version/release scripts (`version_read.php`, `version_bump.php`, `version_check.php`, `version_set_platform.php`, `version_auto_bump.php`, `release_create.php`, `release_package.php`, `release_validate.php`, `version_reset_dev.php`, `manifest_element.php`, `manifest_licensing.php`, `deploy_joomla.php`, `create_repo.php`). That's the repo *metadata* manifest (now API-managed / deleted per the fork workflow), a different migration than the workflows dir. Do NOT lump it in here — changing the manifest path blindly risks breaking version/release reads across all repos. ## Verification done - MokoSuiteBackup dev/main: no nested `.mokogit/.mokogit/`. - Template-Generic / Template-Joomla `.mokogit/`: clean, flat. - `workflow_sync.php` Phase 1/2 use `$workflow['name']` (basename) + `WORKFLOW_DIR = '.mokogit/workflows'` -> cannot nest. Reported from a MokoSuiteBackup session; filed here since the fix belongs in the shared tooling.
jmiller commented 2026-07-16 19:09:09 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/352-fix-stale-mokogitea-workflows-refs-in-sc

git fetch origin
git checkout feature/352-fix-stale-mokogitea-workflows-refs-in-sc
Branch created: [`feature/352-fix-stale-mokogitea-workflows-refs-in-sc`](https://git.mokoconsulting.tech/MokoConsulting/MokoCLI/src/branch/feature/352-fix-stale-mokogitea-workflows-refs-in-sc) ```bash git fetch origin git checkout feature/352-fix-stale-mokogitea-workflows-refs-in-sc ```
jmiller commented 2026-07-17 03:24:16 +00:00
Author
Owner
Copy Link
Copy Source

Resolved: stale .mokogitea/workflows scaffolding refs repointed to .mokogit/workflows across repo_wizard/release/bulk_workflow_push/UnifiedValidation; the .mokogit/.mokogit nesting was cleaned org-wide. Closing.

Resolved: stale .mokogitea/workflows scaffolding refs repointed to .mokogit/workflows across repo_wizard/release/bulk_workflow_push/UnifiedValidation; the .mokogit/.mokogit nesting was cleaned org-wide. Closing.
Sign in to join this conversation.
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?