From 2534fd3cae53a91b64a8a690ec6e4204f749b6ce Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 4 Jan 2026 01:26:21 +0000 Subject: [PATCH] Address code review feedback - improve error handling and use bash built-ins Co-authored-by: jmiller-moko <230051081+jmiller-moko@users.noreply.github.com> --- scripts/run/check_version.sh | 2 +- scripts/validate/workflows.sh | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/run/check_version.sh b/scripts/run/check_version.sh index 910fae6..d36b114 100755 --- a/scripts/run/check_version.sh +++ b/scripts/run/check_version.sh @@ -85,7 +85,7 @@ validate_prefix() { validate_version() { local v="$1" - if ! printf '%s' "$v" | grep -Eq '^[0-9]{2}\.[0-9]{2}\.[0-9]{2}$'; then + if [[ ! "$v" =~ ^[0-9]{2}\.[0-9]{2}\.[0-9]{2}$ ]]; then die "Invalid version format: $v (expected NN.NN.NN)" fi } diff --git a/scripts/validate/workflows.sh b/scripts/validate/workflows.sh index a8a147d..aad70d9 100755 --- a/scripts/validate/workflows.sh +++ b/scripts/validate/workflows.sh @@ -52,7 +52,12 @@ validate_yaml_syntax() { python3 - "$file" <<'PYEOF' import sys -import yaml + +try: + import yaml +except ModuleNotFoundError: + print("WARNING: PyYAML module not installed. Install with: pip3 install pyyaml") + sys.exit(0) file_path = sys.argv[1]