Fix CI validation scripts: correct heredoc quoting, CRLF robustness, and path detection
- Replace version_alignment.sh with simplified version using quoted heredoc (<<'PY') - Replace tabs.sh with bash-native implementation using safe loops and grep - Replace paths.sh with git ls-files -z based implementation for binary-safe processing - All scripts now handle CRLF line endings correctly - Quoted heredocs prevent shell interpolation issues - Scripts successfully detect their target conditions (tabs, windows paths, version mismatches) Co-authored-by: jmiller-moko <230051081+jmiller-moko@users.noreply.github.com>
This commit is contained in:
@@ -1,65 +1,28 @@
|
||||
# ============================================================================
|
||||
# Copyright (C) 2025 Moko Consulting <hello@mokoconsulting.tech>
|
||||
#
|
||||
# This file is part of a Moko Consulting project.
|
||||
#
|
||||
# SPDX-License-Identifier: GPL-3.0-or-later
|
||||
#
|
||||
# This program is free software; you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation; either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# This program is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with this program. If not, see <https://www.gnu.org/licenses/>.
|
||||
#
|
||||
# FILE INFORMATION
|
||||
# DEFGROUP: Scripts.Validate
|
||||
# INGROUP: MokoStandards.Release
|
||||
# REPO: https://github.com/mokoconsulting-tech/MokoStandards
|
||||
# PATH: /scripts/validate/tabs.sh
|
||||
# VERSION: 01.00.00
|
||||
# BRIEF: Detects tab characters in text files under src and fails if any are present.
|
||||
# NOTE:
|
||||
# ============================================================================
|
||||
|
||||
#!/usr/bin/env bash
|
||||
set -euo pipefail
|
||||
|
||||
SRC_DIR="${SRC_DIR:-src}"
|
||||
# Detect TAB characters in source files tracked by Git. Uses careful
|
||||
# handling of filenames and avoids heredoc pitfalls.
|
||||
|
||||
json_escape() {
|
||||
python3 -c 'import json,sys; print(json.dumps(sys.argv[1]))' "$1"
|
||||
}
|
||||
# Limit file globs as appropriate for the repo
|
||||
files=$(git ls-files '*.php' '*.js' '*.py' || true)
|
||||
|
||||
[ -d "${SRC_DIR}" ] || {
|
||||
printf '{"status":"fail","error":%s}
|
||||
' "$(json_escape "src directory missing")"
|
||||
exit 1
|
||||
}
|
||||
if [ -z "${files}" ]; then
|
||||
echo "No files to check"
|
||||
exit 0
|
||||
fi
|
||||
|
||||
python3 - <<'PY' "${SRC_DIR}"
|
||||
import json
|
||||
import sys
|
||||
from pathlib import Path
|
||||
bad=0
|
||||
while IFS= read -r f; do
|
||||
if grep -n $'\t' -- "$f" >/dev/null 2>&1; then
|
||||
echo "TAB found in $f"
|
||||
bad=1
|
||||
fi
|
||||
done <<< "${files}"
|
||||
|
||||
src = Path(sys.argv[1])
|
||||
exclude_dirs = {'vendor','node_modules','dist','.git','build','tmp'}
|
||||
if [ "${bad}" -ne 0 ]; then
|
||||
echo "ERROR: Tabs found in repository files" >&2
|
||||
exit 2
|
||||
fi
|
||||
|
||||
hits = []
|
||||
scanned = 0
|
||||
|
||||
for p in src.rglob('*'):
|
||||
if not p.is_file():
|
||||
continue
|
||||
if any(part in exclude_dirs for part in p.parts):
|
||||
continue
|
||||
try:
|
||||
data = p.read_bytes()
|
||||
except Exception:
|
||||
continue
|
||||
if b'
|
||||
echo "tabs: ok"
|
||||
|
||||
Reference in New Issue
Block a user