MokoConsulting/MokoCassiopeia
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Releases 1 Activity

Address code review feedback

Browse Source 
- Add version component validation in versions.sh
- Add verbose mode to validate_all.sh for debugging
- Update documentation with verbose mode usage
- Improve error messages with hints to use verbose mode

Co-authored-by: jmiller-moko <230051081+jmiller-moko@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-03 21:39:22 +00:00
parent 4bff6c4ad7
commit 62f5325338
3 changed files with 54 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
scripts/run/validate_all.sh
View File

@@ -43,6 +43,13 @@ SCRIPT_DIR="$(cd "$(dirname "$0")/.." && pwd)"
# Configuration
# ----------------------------------------------------------------------------
VERBOSE="${1:-}"
if [ "${VERBOSE}" = "-v" ] || [ "${VERBOSE}" = "--verbose" ]; then
VERBOSE="true"
else
VERBOSE="false"
fi
REQUIRED_CHECKS=(
"manifest"
"xml_wellformed"
@@ -83,12 +90,22 @@ for check in "${REQUIRED_CHECKS[@]}"; do
fi
log_step "Running: ${check}"
if "${script}" >/dev/null 2>&1; then
log_success "✓ ${check}"
required_passed=$((required_passed + 1))
if [ "${VERBOSE}" = "true" ]; then
if "${script}"; then
log_success "✓ ${check}"
required_passed=$((required_passed + 1))
else
log_error "✗ ${check} (FAILED)"
required_failed=$((required_failed + 1))
fi
else
log_error "✗ ${check} (FAILED)"
required_failed=$((required_failed + 1))
if "${script}" >/dev/null 2>&1; then
log_success "✓ ${check}"
required_passed=$((required_passed + 1))
else
log_error "✗ ${check} (FAILED - run with -v for details)"
required_failed=$((required_failed + 1))
fi
fi
done
@@ -104,12 +121,22 @@ for check in "${OPTIONAL_CHECKS[@]}"; do
fi
log_step "Running: ${check}"
if "${script}" >/dev/null 2>&1; then
log_success "✓ ${check}"
optional_passed=$((optional_passed + 1))
if [ "${VERBOSE}" = "true" ]; then
if "${script}"; then
log_success "✓ ${check}"
optional_passed=$((optional_passed + 1))
else
log_warn "✗ ${check} (warnings/issues found)"
optional_failed=$((optional_failed + 1))
fi
else
log_warn "✗ ${check} (warnings/issues found)"
optional_failed=$((optional_failed + 1))
if "${script}" >/dev/null 2>&1; then
log_success "✓ ${check}"
optional_passed=$((optional_passed + 1))
else
log_warn "✗ ${check} (warnings/issues found - run with -v for details)"
optional_failed=$((optional_failed + 1))
fi
fi
done