From 8159b134a535cfb61ccebcebd678047193f56cb1 Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sat, 7 Mar 2026 20:53:18 +0000
Subject: [PATCH] Address final code review feedback
- Add setup notes to font CSS files about required downloads
- Restore alert-warning class for font note (important setup info)
- Fix alignment in success message border
Co-authored-by: jmiller-moko <230051081+jmiller-moko@users.noreply.github.com>
---
scripts/download-google-fonts.sh | 6 +++---
src/media/css/fonts/fira-sans.css | 14 ++++++++++++++
src/media/css/fonts/noto-sans.css | 14 ++++++++++++++
src/media/css/fonts/roboto.css | 14 ++++++++++++++
src/templateDetails.xml | 2 +-
5 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/scripts/download-google-fonts.sh b/scripts/download-google-fonts.sh
index e3e0ed7..dc861b1 100755
--- a/scripts/download-google-fonts.sh
+++ b/scripts/download-google-fonts.sh
@@ -84,9 +84,9 @@ download_font "roboto" "https://fonts.googleapis.com/css2?family=Roboto:wght@100
download_font "noto-sans" "https://fonts.googleapis.com/css2?family=Noto+Sans:wght@100;300;400;700&display=swap" "Noto Sans"
download_font "fira-sans" "https://fonts.googleapis.com/css2?family=Fira+Sans:wght@100;300;400;700&display=swap" "Fira Sans"
-echo -e "${GREEN}╔═══════════════════════════════════════════╗${NC}"
-echo -e "${GREEN}║ ✓ All fonts downloaded successfully! ║${NC}"
-echo -e "${GREEN}╚═══════════════════════════════════════════╝${NC}"
+echo -e "${GREEN}╔════════════════════════════════════════════╗${NC}"
+echo -e "${GREEN}║ ✓ All fonts downloaded successfully! ║${NC}"
+echo -e "${GREEN}╚════════════════════════════════════════════╝${NC}"
echo ""
echo -e "Font files saved to: ${BLUE}$(pwd)${NC}"
echo ""
diff --git a/src/media/css/fonts/fira-sans.css b/src/media/css/fonts/fira-sans.css
index 295e41b..1c17706 100644
--- a/src/media/css/fonts/fira-sans.css
+++ b/src/media/css/fonts/fira-sans.css
@@ -13,6 +13,20 @@
BRIEF: Fira Sans font family definitions (self-hosted)
*/
+/*
+ * IMPORTANT: Font files must be downloaded separately
+ *
+ * This CSS file references Fira Sans font files that must be manually downloaded
+ * and placed in the fonts directory. See GOOGLE_FONTS_README.md in the fonts
+ * directory for download instructions.
+ *
+ * Required files:
+ * - fira-sans-v17-latin-100.woff2
+ * - fira-sans-v17-latin-300.woff2
+ * - fira-sans-v17-latin-regular.woff2
+ * - fira-sans-v17-latin-700.woff2
+ */
+
/* Fira Sans Thin (100) */
@font-face {
font-family: 'Fira Sans';
diff --git a/src/media/css/fonts/noto-sans.css b/src/media/css/fonts/noto-sans.css
index dbb9f26..c011dd1 100644
--- a/src/media/css/fonts/noto-sans.css
+++ b/src/media/css/fonts/noto-sans.css
@@ -13,6 +13,20 @@
BRIEF: Noto Sans font family definitions (self-hosted)
*/
+/*
+ * IMPORTANT: Font files must be downloaded separately
+ *
+ * This CSS file references Noto Sans font files that must be manually downloaded
+ * and placed in the fonts directory. See GOOGLE_FONTS_README.md in the fonts
+ * directory for download instructions.
+ *
+ * Required files:
+ * - noto-sans-v36-latin-100.woff2
+ * - noto-sans-v36-latin-300.woff2
+ * - noto-sans-v36-latin-regular.woff2
+ * - noto-sans-v36-latin-700.woff2
+ */
+
/* Noto Sans Thin (100) */
@font-face {
font-family: 'Noto Sans';
diff --git a/src/media/css/fonts/roboto.css b/src/media/css/fonts/roboto.css
index 3d259b0..bf68f47 100644
--- a/src/media/css/fonts/roboto.css
+++ b/src/media/css/fonts/roboto.css
@@ -13,6 +13,20 @@
BRIEF: Roboto font family definitions (self-hosted)
*/
+/*
+ * IMPORTANT: Font files must be downloaded separately
+ *
+ * This CSS file references Roboto font files that must be manually downloaded
+ * and placed in the fonts directory. See GOOGLE_FONTS_README.md in the fonts
+ * directory for download instructions.
+ *
+ * Required files:
+ * - roboto-v30-latin-100.woff2
+ * - roboto-v30-latin-300.woff2
+ * - roboto-v30-latin-regular.woff2
+ * - roboto-v30-latin-700.woff2
+ */
+
/* Roboto Thin (100) */
@font-face {
font-family: 'Roboto';
diff --git a/src/templateDetails.xml b/src/templateDetails.xml
index 676d8a9..a1b8f2b 100644
--- a/src/templateDetails.xml
+++ b/src/templateDetails.xml
@@ -206,7 +206,7 @@
-
+