From 8d6a8df15e849163e511d6e2ce37522d8ea3a5de Mon Sep 17 00:00:00 2001
From: Jonathan Miller <230051081+jmiller-moko@users.noreply.github.com>
Date: Wed, 8 Apr 2026 05:14:05 -0500
Subject: [PATCH] Fix horizontal menu: use own sub-layouts, unique collapse ID

horizontal.php was referencing mainmenu_ sub-layouts instead of
horizontal_ ones. Also use module ID in collapse target to avoid
conflicts when multiple menus exist on the same page.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 src/html/mod_menu/horizontal.php | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/html/mod_menu/horizontal.php b/src/html/mod_menu/horizontal.php
index e664177..d24ffcb 100644
--- a/src/html/mod_menu/horizontal.php
+++ b/src/html/mod_menu/horizontal.php
@@ -30,12 +30,12 @@ $moduleclass_sfx = htmlspecialchars($params->get('moduleclass_sfx', ''), ENT_COM
 <nav class="mod-menu mod-menu-main navbar navbar-expand-lg<?php echo $moduleclass_sfx; ?>"<?php echo $id; ?>>
     <div class="container-fluid">
         <!-- Hamburger toggle button for mobile -->
-        <button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#mainMenuCollapse" aria-controls="mainMenuCollapse" aria-expanded="false" aria-label="Toggle Main Menu">
+        <button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#horizontalMenuCollapse-<?php echo $module->id; ?>" aria-controls="horizontalMenuCollapse-<?php echo $module->id; ?>" aria-expanded="false" aria-label="Toggle Menu">
             <span class="fa-solid fa-bars" aria-hidden="true"></span>
         </button>
 
         <!-- Collapsible menu content -->
-        <div class="collapse navbar-collapse" id="mainMenuCollapse">
+        <div class="collapse navbar-collapse" id="horizontalMenuCollapse-<?php echo $module->id; ?>">
             <ul class="navbar-nav mod-menu-main__list">
 <?php foreach ($list as $i => &$item) :
     $itemParams = $item->getParams();
@@ -80,11 +80,11 @@ $moduleclass_sfx = htmlspecialchars($params->get('moduleclass_sfx', ''), ENT_COM
         case 'component':
         case 'heading':
         case 'url':
-            require ModuleHelper::getLayoutPath('mod_menu', 'mainmenu_' . $item->type);
+            require ModuleHelper::getLayoutPath('mod_menu', 'horizontal_' . $item->type);
             break;
 
         default:
-            require ModuleHelper::getLayoutPath('mod_menu', 'mainmenu_url');
+            require ModuleHelper::getLayoutPath('mod_menu', 'horizontal_url');
             break;
     endswitch;