mod_finder override uses wrong language keys and missing JS setup #112

New Issue

2026-04-03T03:56:19Z

jmiller-moko commented

2026-04-03 03:56:19 +00:00

(Migrated from github.com)

Description

The mod_finder template override at html/mod_finder/default.php was not loading language strings correctly and was missing critical JavaScript setup.

Root Cause

Used COM_FINDER_SEARCH_LABEL instead of the correct keys: MOD_FINDER_SEARCH_VALUE and JSEARCH_FILTER_SUBMIT
Missing com_finder.finder script registration
Missing awesomplete preset for autocomplete
Missing Text::script() calls for JS-side language strings
Used Factory::getApplication() instead of the $app variable provided by the module dispatcher

Fix Applied

Rewrote the override to match Joomla's core mod_finder contract:

Correct language keys loaded via $app->getLanguage()->load('com_finder', JPATH_SITE)
WebAsset registry for com_finder extension loaded
awesomplete preset and com_finder.finder script properly registered
show_label, show_button, show_advanced parameters supported
FinderHelper::getHiddenFields() called for proper form routing

Status

Fixed in commit 8b49ff6.

## Description The `mod_finder` template override at `html/mod_finder/default.php` was not loading language strings correctly and was missing critical JavaScript setup. ## Root Cause - Used `COM_FINDER_SEARCH_LABEL` instead of the correct keys: `MOD_FINDER_SEARCH_VALUE` and `JSEARCH_FILTER_SUBMIT` - Missing `com_finder.finder` script registration - Missing `awesomplete` preset for autocomplete - Missing `Text::script()` calls for JS-side language strings - Used `Factory::getApplication()` instead of the `$app` variable provided by the module dispatcher ## Fix Applied Rewrote the override to match Joomla's core `mod_finder` contract: - Correct language keys loaded via `$app->getLanguage()->load('com_finder', JPATH_SITE)` - WebAsset registry for `com_finder` extension loaded - `awesomplete` preset and `com_finder.finder` script properly registered - `show_label`, `show_button`, `show_advanced` parameters supported - `FinderHelper::getHiddenFields()` called for proper form routing ## Status Fixed in commit `8b49ff6`.

jmiller-moko commented

2026-04-04 16:55:44 +00:00

(Migrated from github.com)

Fixed in commit 8b49ff6.

The mod_finder override was rewritten to match the Joomla core contract:

Corrected language keys: MOD_FINDER_SEARCH_VALUE and JSEARCH_FILTER_SUBMIT (previously used wrong COM_FINDER_SEARCH_LABEL)
Added com_finder language file loading via $app->getLanguage()->load('com_finder', JPATH_SITE)
Registered com_finder.finder script and awesomplete preset in the WebAsset Manager
Added Text::script() calls for JS-side language strings
Replaced Factory::getApplication() with the module-provided $app variable
Added support for show_label, show_button, and show_advanced parameters
Called FinderHelper::getHiddenFields() for proper form routing

**Fixed in commit `8b49ff6`.** The mod_finder override was rewritten to match the Joomla core contract: - Corrected language keys: `MOD_FINDER_SEARCH_VALUE` and `JSEARCH_FILTER_SUBMIT` (previously used wrong `COM_FINDER_SEARCH_LABEL`) - Added `com_finder` language file loading via `$app->getLanguage()->load('com_finder', JPATH_SITE)` - Registered `com_finder.finder` script and `awesomplete` preset in the WebAsset Manager - Added `Text::script()` calls for JS-side language strings - Replaced `Factory::getApplication()` with the module-provided `$app` variable - Added support for `show_label`, `show_button`, and `show_advanced` parameters - Called `FinderHelper::getHiddenFields()` for proper form routing

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCassiopeia#112