mod_footer override used wrong data source — ->content instead of $lineone #113

Closed
opened 2026-04-03 03:56:32 +00:00 by jmiller-moko · 1 comment
jmiller-moko commented 2026-04-03 03:56:32 +00:00 (Migrated from github.com)

Description

The mod_footer template override at html/mod_footer/default.php was rendering blank or incorrect content because it used $module->content instead of the module's prepared $lineone variable.

Root Cause

mod_footer is not a custom HTML module — it generates its own copyright/year line via a helper that populates the $lineone variable. The override incorrectly treated it like mod_custom and rendered $module->content, which is empty for this module type.

Additionally, the MOD_FOOTER_LINE2 ("Joomla! is Free Software...") language string was not being output.

Fix Applied

  • Replaced $module->content with $lineone (the prepared footer text)
  • Added Text::_('MOD_FOOTER_LINE2') output
  • Used BEM class names .mod-footer__line1 / .mod-footer__line2

Status

Fixed in commit 8b49ff6.

## Description The `mod_footer` template override at `html/mod_footer/default.php` was rendering blank or incorrect content because it used `$module->content` instead of the module's prepared `$lineone` variable. ## Root Cause `mod_footer` is not a custom HTML module — it generates its own copyright/year line via a helper that populates the `$lineone` variable. The override incorrectly treated it like `mod_custom` and rendered `$module->content`, which is empty for this module type. Additionally, the `MOD_FOOTER_LINE2` ("Joomla! is Free Software...") language string was not being output. ## Fix Applied - Replaced `$module->content` with `$lineone` (the prepared footer text) - Added `Text::_('MOD_FOOTER_LINE2')` output - Used BEM class names `.mod-footer__line1` / `.mod-footer__line2` ## Status Fixed in commit `8b49ff6`.
jmiller-moko commented 2026-04-04 16:55:51 +00:00 (Migrated from github.com)

Fixed in commit 8b49ff6. The mod_footer override was using $module->content (empty for this module type) instead of the prepared $lineone variable. Fixed to use $lineone and added MOD_FOOTER_LINE2 output.

Fixed in commit 8b49ff6. The mod_footer override was using $module->content (empty for this module type) instead of the prepared $lineone variable. Fixed to use $lineone and added MOD_FOOTER_LINE2 output.
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCassiopeia#113