MokoConsulting/MokoGIT
1
0
Fork 0
Code Issues 146 Pull Requests Releases 96 Wiki Activity

fix: lowercase and clean Joomla element names (#635) #643

Closed
jmiller wants to merge 1 commits from fix/635-joomla-element-name into main
pull from: fix/635-joomla-element-name
merge into: :main
Conversation 0 Commits 1 Files Changed 1
+22 -4
jmiller commented 2026-06-18 19:55:20 +00:00
Owner
Copy Link
Copy Source

Summary

AutoElementName() was using m.Name directly without lowercasing or character cleaning, producing elements like pkg_MokoSuiteBackup instead of pkg_mokosuitebackup.

Joomla's InstallerAdapter::getElement() always calls strtolower(InputFilter::clean($element, 'cmd')) — which lowercases and strips all characters except [a-z0-9._-].

Changes

  • Added cleanJoomlaElement() function that replicates Joomla's InputFilter::clean('cmd') behavior
  • AutoElementName() now runs the name through cleanJoomlaElement() before prefixing
  • Removed incorrect \"plugin\": \"plg_\" from prefix map — Joomla plugins use bare element names

Before/After

Repo Before After
MokoSuiteBackup (package) pkg_MokoSuiteBackup pkg_mokosuitebackup
MokoJoomHero (module) mod_MokoJoomHero mod_mokojoomhero
MokoOnyx (template) tpl_MokoOnyx tpl_mokoonyx

Fixes #635

Test plan

  • updates.xml for MokoSuiteBackup shows <element>pkg_mokosuitebackup</element>
  • Joomla admin sees available update after deploying this fix
  • Manifest API still returns the original cased name in element_name field
## Summary `AutoElementName()` was using `m.Name` directly without lowercasing or character cleaning, producing elements like `pkg_MokoSuiteBackup` instead of `pkg_mokosuitebackup`. Joomla's `InstallerAdapter::getElement()` always calls `strtolower(InputFilter::clean($element, 'cmd'))` — which lowercases and strips all characters except `[a-z0-9._-]`. ### Changes - Added `cleanJoomlaElement()` function that replicates Joomla's `InputFilter::clean('cmd')` behavior - `AutoElementName()` now runs the name through `cleanJoomlaElement()` before prefixing - Removed incorrect `\"plugin\": \"plg_\"` from prefix map — Joomla plugins use bare element names ### Before/After | Repo | Before | After | |------|--------|-------| | MokoSuiteBackup (package) | `pkg_MokoSuiteBackup` | `pkg_mokosuitebackup` | | MokoJoomHero (module) | `mod_MokoJoomHero` | `mod_mokojoomhero` | | MokoOnyx (template) | `tpl_MokoOnyx` | `tpl_mokoonyx` | Fixes #635 ## Test plan - [ ] `updates.xml` for MokoSuiteBackup shows `<element>pkg_mokosuitebackup</element>` - [ ] Joomla admin sees available update after deploying this fix - [ ] Manifest API still returns the original cased name in `element_name` field
jmiller added 1 commit 2026-06-18 19:55:23 +00:00
fix: lowercase and clean Joomla element names in AutoElementName (#635)
Branch Policy Check / Verify merge target (pull_request) Failing after 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Generic: Repo Health / Access control (push) Successful in 2s
Details
Generic: Repo Health / Site Health (push) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Has been skipped
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: Auto Version Bump / Version Bump (push) Successful in 8s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 41s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Universal: Secret Scanning / Gitleaks Secret Scan (pull_request) Successful in 46s
Details
PR RC Release / Build RC Release (pull_request) Failing after 46s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (push) Has been cancelled
Details
Generic: Repo Health / Repository health (push) Has been cancelled
Details
Generic: Repo Health / Report Issues (push) Has been cancelled
Details
dbd6103acb 
AutoElementName() was using m.Name directly without lowercasing or
cleaning, producing elements like pkg_MokoSuiteBackup instead of
pkg_mokosuitebackup. Joomla's InstallerAdapter always lowercases
and runs InputFilter::clean('cmd') which strips non-alphanumeric
chars (except . _ -).

Added cleanJoomlaElement() to replicate Joomla's cmd filter.
Removed incorrect "plugin": "plg_" prefix — Joomla plugins use
bare element names without a prefix.

Fixes #635
jmiller closed this pull request 2026-06-18 19:55:39 +00:00
jmiller deleted branch fix/635-joomla-element-name 2026-06-18 19:55:40 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGIT#643
Delete Branch "fix/635-joomla-element-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?