MokoConsulting/MokoGIT
1
0
Fork 0
Code Issues 146 Pull Requests Releases 96 Wiki Activity

[Bug] App icon (logo.png) does not follow the Branding nav-icon #773

New Issue
Closed
opened 2026-07-12 23:40:34 +00:00 by jmiller · 0 comments
jmiller commented 2026-07-12 23:40:34 +00:00
Owner
Copy Link
Copy Source

Summary

Admin Branding settings let an admin upload a custom nav-icon (logo-small.png), login-logo, and favicon (favicon.png) into custom/public/assets/img/. But the app icon — logo.png — has no settings control, so it stays the shipped default even after the instance is otherwise fully branded.

logo.png is used as:

  • the 512x512 PWA / web-manifest icon (routers/web/misc/misc.go SiteManifest), and
  • the navbar logo fallback (templates/base/head_navbar.tmpl onerror).

So a branded instance still shows the default MokoGitea mark as its installable app icon.

Expected

When the admin uploads the nav-icon, the app icon (logo.png) should default to the same image; resetting the nav-icon should also revert the app icon.

Fix

  • routers/web/admin/branding.go: on nav-icon upload, also write logo.png; on nav-icon reset, also remove logo.png.
  • Branding template: note that the nav icon also sets the app icon.

/kind bug

## Summary Admin **Branding** settings let an admin upload a custom **nav-icon** (`logo-small.png`), **login-logo**, and **favicon** (`favicon.png`) into `custom/public/assets/img/`. But the **app icon** — `logo.png` — has no settings control, so it stays the shipped default even after the instance is otherwise fully branded. `logo.png` is used as: - the 512x512 PWA / web-manifest icon (`routers/web/misc/misc.go` `SiteManifest`), and - the navbar logo fallback (`templates/base/head_navbar.tmpl` `onerror`). So a branded instance still shows the default MokoGitea mark as its installable app icon. ## Expected When the admin uploads the **nav-icon**, the app icon (`logo.png`) should default to the same image; resetting the nav-icon should also revert the app icon. ## Fix - `routers/web/admin/branding.go`: on nav-icon upload, also write `logo.png`; on nav-icon reset, also remove `logo.png`. - Branding template: note that the nav icon also sets the app icon. /kind bug
Sign in to join this conversation.
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGIT#773
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?