feat(updateserver): npm/mcp return N-A instead of Joomla feed; derive platform from metadata [#810 #811] #825

Merged

jmiller merged 1 commits from feature/updateserver-npm-mcp into dev 2026-07-19 02:49:06 +00:00

Conversation 0 Commits 1 Files Changed 4

+122 -25

jmiller commented 2026-07-19 02:08:53 +00:00

Owner

Copy Link

Copy Source

Summary

Fixes #810 and #811.

#810 — npm/mcp must not emit a Joomla (or any legacy) feed

Every Serve* update-feed handler in routers/web/repo/updateserver.go now gates positively on its own platform constant. Previously ServeUpdatesXML used platform != "" && platform != "joomla" && platform != "both", so an unset platform fell through to GenerateJoomlaXML (the "empty ⇒ joomla" fallback). Now:

• ServeUpdatesXML serves only for joomla/both.
• ServeDolibarrJSON serves only for dolibarr/both (previously served for any non-joomla/non-empty platform — tightened).
• WordPress/Composer/PrestaShop/Drupal/WHMCS unchanged in effect, converted to named constants.
• npm/mcp (and any unrecognized platform) now return ctx.NotFound(nil).

Added models/updateserver/platform.go with platform constants, IsFeedlessPlatform(npm/mcp), and ResolvePlatform.

#811 — derive effective platform from metadata.platform

The resolved RepoUpdatePlatform context value now comes from updateserver_model.ResolvePlatform(cfgPlatform, metadataPlatform):

1. explicit update-stream config platform wins;
2. else derive from repo metadata (RepoMetadata.Platform, read via GetRepoMetadata);
3. else fall back to joomla.

Applied in both places that set RepoUpdatePlatform: services/context/repo_public_feed.go (feed endpoints) and services/context/repo.go (release-page UI). This stops the two platform stores from drifting and removes the blanket "empty ⇒ joomla" fallback at its root.

Schema / migration

No migration required. UpdateStreamConfig.Platform is a plain string column (NOT NULL DEFAULT 'joomla') with no DB-level enum/CHECK constraint, and RepoMetadata.Platform is a free VARCHAR(50). npm/mcp are enforced at the application layer only.

Files changed

• models/updateserver/platform.go (new)
• routers/web/repo/updateserver.go
• services/context/repo_public_feed.go
• services/context/repo.go

Build / deploy

Not built/deployed — requires forge rebuild + redeploy; review signatures against the deployed version. No Go toolchain was available in the authoring environment, so gofmt/go vet were not run; formatting was applied manually (tabs, import ordering). The base branch is dev.

https://claude.ai/code/session_015UauDPfYC8S2mdUhoSK8zQ

## Summary Fixes #810 and #811. ### #810 — npm/mcp must not emit a Joomla (or any legacy) feed Every `Serve*` update-feed handler in `routers/web/repo/updateserver.go` now gates **positively** on its own platform constant. Previously `ServeUpdatesXML` used `platform != "" && platform != "joomla" && platform != "both"`, so an **unset** platform fell through to `GenerateJoomlaXML` (the "empty ⇒ joomla" fallback). Now: - `ServeUpdatesXML` serves only for `joomla`/`both`. - `ServeDolibarrJSON` serves only for `dolibarr`/`both` (previously served for *any* non-joomla/non-empty platform — tightened). - WordPress/Composer/PrestaShop/Drupal/WHMCS unchanged in effect, converted to named constants. - `npm`/`mcp` (and any unrecognized platform) now return `ctx.NotFound(nil)`. Added `models/updateserver/platform.go` with platform constants, `IsFeedlessPlatform(npm/mcp)`, and `ResolvePlatform`. ### #811 — derive effective platform from `metadata.platform` The resolved `RepoUpdatePlatform` context value now comes from `updateserver_model.ResolvePlatform(cfgPlatform, metadataPlatform)`: 1. explicit update-stream config platform wins; 2. else derive from repo metadata (`RepoMetadata.Platform`, read via `GetRepoMetadata`); 3. else fall back to `joomla`. Applied in both places that set `RepoUpdatePlatform`: `services/context/repo_public_feed.go` (feed endpoints) and `services/context/repo.go` (release-page UI). This stops the two platform stores from drifting and removes the blanket "empty ⇒ joomla" fallback at its root. ### Schema / migration **No migration required.** `UpdateStreamConfig.Platform` is a plain string column (`NOT NULL DEFAULT 'joomla'`) with no DB-level enum/CHECK constraint, and `RepoMetadata.Platform` is a free `VARCHAR(50)`. `npm`/`mcp` are enforced at the application layer only. ### Files changed - `models/updateserver/platform.go` (new) - `routers/web/repo/updateserver.go` - `services/context/repo_public_feed.go` - `services/context/repo.go` ## Build / deploy **Not built/deployed — requires forge rebuild + redeploy; review signatures against the deployed version.** No Go toolchain was available in the authoring environment, so `gofmt`/`go vet` were not run; formatting was applied manually (tabs, import ordering). The base branch is `dev`. https://claude.ai/code/session_015UauDPfYC8S2mdUhoSK8zQ

jmiller added 1 commit 2026-07-19 02:08:55 +00:00

feat(updateserver): npm/mcp return N-A instead of Joomla feed; derive platform from metadata [#810 #811] ... 9a8d9bc504

#810: The update-feed handlers no longer fall back to a Joomla feed for
unset or feedless platforms. Every Serve* handler now gates positively on
its own platform constant, so npm/mcp (and any unrecognized platform)
return NotFound instead of an (empty) Joomla updates.xml. Added npm/mcp as
recognized platform constants and an IsFeedlessPlatform helper.

#811: The effective update-stream platform (RepoUpdatePlatform) is now
resolved via ResolvePlatform(cfgPlatform, metadataPlatform): an explicit
update-stream config platform wins; otherwise it derives from the repo
metadata platform (metadata.platform); only when neither is set does it
fall back to "joomla". This stops the update-stream store and the repo
metadata store from drifting and removes the "empty => joomla" fallback
at its root (services/context/repo_public_feed.go and repo.go).

No schema/migration required: UpdateStreamConfig.Platform is a plain string
column with no DB-level enum/CHECK constraint, so npm/mcp are enforced at
the application layer only.

Authored-by: Moko Consulting

jmiller referenced this issue from a commit 2026-07-19 02:29:22 +00:00

feat(platform): structured platform registry + /api/v1/platforms; update server reads registry [#367]

jmiller referenced this pull request 2026-07-19 02:30:28 +00:00

feat(platform): structured platform registry + /api/v1/platforms; update server reads registry [#367] #826

jmiller merged commit 0efb0eb7bc into dev 2026-07-19 02:49:06 +00:00

jmiller deleted branch feature/updateserver-npm-mcp 2026-07-19 02:49:07 +00:00

jmiller referenced this pull request 2026-07-19 03:01:33 +00:00

release: npm/mcp metadata + platform registry + update-server + packaging hook (dev -> main) [#367] #828

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

breaking-change

Breaking API or behavior change

ci-cd

CI/CD pipeline changes

config

Configuration changes

dependencies

Dependency updates

deploy-failure

Deployment failed

docker

Docker/container changes

documentation

Documentation changes

feature: wiki

Wiki system enhancements

good first issue

Good for newcomers

health-check

Repo health check result

help wanted

Extra attention needed

mokostandards

Related to MokoStandards framework

push-failure

Git push operation failed

security

Security vulnerability or hardening

size/l

200-500 lines changed

size/m

50-200 lines changed

size/s

10-50 lines changed

size/xl

500+ lines changed

size/xs

< 10 lines changed

standards-drift

Deviates from MokoStandards

standards-update

MokoStandards compliance update

sync-failure

Sync or mirror failed

tech-debt

Technical debt and TODO/FIXME items

upstream

upstream

Inherited from upstream Gitea

work-in-progress

Draft or incomplete work

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGIT#825