MokoConsulting/MokoGIT
1
0
Fork 0
Code Issues 161 Pull Requests 2 Releases 97 Wiki Activity

fix(updateserver): pick installable package zip, not the source archive #843

Merged
jmiller merged 1 commits from fix/joomla-update-artifact-selection into dev 2026-07-20 11:36:04 +00:00
Conversation 0 Commits 1 Files Changed 1
+50 -8
jmiller commented 2026-07-20 11:35:49 +00:00
Owner
Copy Link
Copy Source

The Joomla update feed picked the FIRST .zip attachment on a release. Releases carrying extra zips (<repo>-<channel>-source.zip alongside pkg_*.zip) advertised the raw source archive, so Joomla downloaded a non-installable zip and failed with Install path does not exist (prerelease/dev channels; stable had one pkg_ zip so was unaffected).

Adds selectJoomlaArtifact(): prefer an extension-prefixed zip (pkg_/com_/mod_/plg_/tpl_/lib_) that is not a -source archive, then any non-source zip, then any zip.

The Joomla update feed picked the FIRST .zip attachment on a release. Releases carrying extra zips (`<repo>-<channel>-source.zip` alongside `pkg_*.zip`) advertised the raw source archive, so Joomla downloaded a non-installable zip and failed with **Install path does not exist** (prerelease/dev channels; stable had one `pkg_` zip so was unaffected). Adds `selectJoomlaArtifact()`: prefer an extension-prefixed zip (`pkg_/com_/mod_/plg_/tpl_/lib_`) that is not a `-source` archive, then any non-source zip, then any zip.
jmiller added 1 commit 2026-07-20 11:35:50 +00:00
fix(updateserver): pick installable package zip, not the source archive
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 42s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 1m16s
Details
Generic: Project CI / Tests (pull_request) Successful in 1m2s
Details
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 6s
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Details
Universal: PR Check / Validate PR (pull_request) Successful in 48s
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 1m47s
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
376f644872 
The Joomla update feed took the FIRST .zip attachment on a release as the
download URL. Releases that carry extra zips (e.g. <repo>-<channel>-source.zip
alongside pkg_*.zip) then advertised the raw SOURCE archive, so Joomla
downloaded a non-installable zip and failed with "Install path does not exist"
(affected prerelease/dev channels; stable had a single pkg_ zip so was fine).

Add selectJoomlaArtifact(): prefer an extension-prefixed zip
(pkg_/com_/mod_/plg_/tpl_/lib_) that is not a "-source" archive, then any
non-source zip, then any zip.

Authored-by: Moko Consulting
jmiller merged commit 47e04ae77a into dev 2026-07-20 11:36:04 +00:00
jmiller deleted branch fix/joomla-update-artifact-selection 2026-07-20 11:36:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGIT#843
Delete Branch "fix/joomla-update-artifact-selection"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?