feat(licenses): UI/UX cleanup, permissions system, and key management improvements #306

2026-05-31T14:08:47Z

jmiller commented

2026-05-31 14:08:47 +00:00

Summary

Merges dev into main after PR #305 is validated.

Includes:

License UI/UX cleanup (modal confirms, clipboard, localization, compact tables)
TypeLicenses unit permission system
Admin teams inherit all unit permissions (fixes #304)
Key renewal, auto-domain association, custom key input

Test plan

See PR #305 for full test checklist.

Generated with Claude Code

## Summary Merges dev into main after PR #305 is validated. Includes: - License UI/UX cleanup (modal confirms, clipboard, localization, compact tables) - TypeLicenses unit permission system - Admin teams inherit all unit permissions (fixes #304) - Key renewal, auto-domain association, custom key input ## Test plan See PR #305 for full test checklist. --- Generated with [Claude Code](https://claude.com/claude-code)

jmiller added 5 commits 2026-05-31 14:21:10 +00:00

feat(licenses): implement full commercial license management system b77da17f38

Add key editing, domain enforcement, purchase webhooks, public
validation API, channels multiselect, Joomla downloadkey element,
licensing feature toggle, unified update system, release tag
enforcement, heartbeat tracking, and improved settings UX.

Phase 1: Full key display with AbsoluteShort dates, master package
protection (hide edit/delete in UI, reject in handlers).

Phase 2: Key edit page with template, handlers, and routes for both
repo and org levels. Master keys redirect away.

Phase 3: Domain restriction checking against CSV allowlist,
MaxSites enforcement via CountUniqueDomainsByKey and
IsDomainKnownForKey, dlid query param support for Joomla.

Phase 4: Purchase webhook (POST /license-keys/purchase) with
PaymentRef idempotency. Public validation endpoint
(POST /license-keys/validate) outside auth middleware.
PATCH /license-keys/{id} for API key editing.

Phase 5: Channels multiselect using org UpdateStreamConfig streams
rendered as checkboxes, stored as JSON arrays.

Additional: downloadkey XML element, LicensingEnabled toggle on
UpdateStreamConfig, Dolibarr endpoint unified with key validation,
release tag suffix enforcement, LastHeartbeatUnix field with
TouchHeartbeat, and cleaned-up settings pages.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

feat(licenses): UI/UX cleanup, permissions, renew, auto-domain, custom keys ed79a48119

- Replace confirm() with Gitea modal system (link-action + data-modal-confirm)
- Add confirmation modal to revoke key action
- Fix clipboard copy to use data-clipboard-target with tooltip feedback
- Localize all hardcoded English strings (feed labels, "unlimited", "Master")
- Improve key creation flash with security-focused message + copy button
- Add count badge to org licenses nav tab
- Add icon to org settings navbar for update streams
- Add help text to "Active" checkboxes explaining deactivation impact
- Fix empty state message to reference UI creation (not just API)
- Compact tables for denser license data display
- Add orange "Master" label to master package rows
- Conditional feed buttons on release page (only when licensing enabled)
- Add TypeLicenses unit type with Read/Write/Admin team permissions
- Route-level permission enforcement via RequireUnitReader/Writer
- Add "Renew" action for license keys (extends by package duration)
- Auto-associate domain on first heartbeat (lock-on-first-use)
- Enforce max_sites limit during domain auto-association
- Allow site admins and org owners to set custom license key values

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(permissions): admin teams implicitly inherit access to all unit types 1a4d0739db

Admin-level teams (team.authorize >= Admin) now implicitly get admin
access to all unit types in UnitMaxAccess(), even without explicit
TeamUnit records. This resolves the long-standing TEAM-UNIT-PERMISSION
issue where adding new units (like TypeLicenses) left existing admin
teams without access.

Resolves: #304

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

fix(licenses): pass IsOrganizationOwner to org licenses template

Branch Policy Check / Verify merge target (pull_request) Successful in 2s

Details

Universal: PR Check / Branch Policy (pull_request) Successful in 1s

Details

PR RC Release / Build RC Release (pull_request) Successful in 2s

Details

Universal: PR Check / Validate PR (pull_request) Failing after 5s

Details

Branch Cleanup / Delete merged branch (pull_request) Successful in 1s

Details

Universal: PR Check / Build RC Package (pull_request) Has been cancelled

Details

c20139393d

Required for the custom key input field visibility check.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge pull request 'feat(licenses): UI/UX cleanup, permissions system, and key management improvements' (#305 ) from fix/admin-delete-only into dev

Branch Policy Check / Verify merge target (pull_request) Successful in 1s

Details

Universal: PR Check / Branch Policy (pull_request) Successful in 1s

Details

Universal: PR Check / Validate PR (pull_request) Failing after 7s

Details

PR RC Release / Build RC Release (pull_request) Successful in 26s

Details

Branch Cleanup / Delete merged branch (pull_request) Has been skipped

Details

Universal: PR Check / Build RC Package (pull_request) Has been cancelled

Details

e6afc9f8c3

jmiller merged commit bfa9043bc8 into main

2026-05-31 14:22:09 +00:00

Sign in to join this conversation.

Priority -

Type -

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#306