MokoConsulting/MokoGitea-APP
1
0
Fork 0
Code Issues 171 Pull Requests 1 Releases 96 Wiki Activity

fix: return 404 for update feeds when update server is disabled (#589) #599

Merged
jmiller merged 1 commits from fix/589-feed-disabled-check into main 2026-06-11 21:12:45 +00:00
Conversation 0 Commits 1 Files Changed 1
+10 -5
jmiller commented 2026-06-11 20:44:10 +00:00
Owner
Copy Link
Copy Source

Summary

  • Feed endpoints (/updates.xml, etc.) now return 404 when the update server is disabled
  • RepoAssignmentPublicFeed middleware checks LicensingEnabled on the effective config (repo → org cascade)
  • Previously, feeds responded with valid data even when the feature was toggled off

Changes

  • services/context/repo_public_feed.go: Replace GetRepoConfig with GetEffectiveConfig, check LicensingEnabled before allowing access

Closes #589

## Summary - Feed endpoints (`/updates.xml`, etc.) now return 404 when the update server is disabled - `RepoAssignmentPublicFeed` middleware checks `LicensingEnabled` on the effective config (repo → org cascade) - Previously, feeds responded with valid data even when the feature was toggled off ## Changes - `services/context/repo_public_feed.go`: Replace `GetRepoConfig` with `GetEffectiveConfig`, check `LicensingEnabled` before allowing access Closes #589
jmiller added 1 commit 2026-06-11 20:44:11 +00:00
fix: return 404 for update feeds when update server is disabled (#589)
Generic: Repo Health / Scripts governance (push) Blocked by required conditions
Details
Generic: Repo Health / Repository health (push) Blocked by required conditions
Details
Generic: Repo Health / Report Issues (push) Blocked by required conditions
Details
Generic: Repo Health / Site Health (push) Has been skipped
Details
Generic: Repo Health / Access control (push) Successful in 1s
Details
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Details
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Repository health (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Report Issues (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Branch Policy Check / Verify merge target (pull_request) Failing after 1s
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 8s
Details
PR RC Release / Build RC Release (pull_request) Failing after 1m3s
Details
Universal: Secret Scanning / Gitleaks Secret Scan (pull_request) Successful in 1m6s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 2s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Failing after 33s
Details
7f3785e7de 
The RepoAssignmentPublicFeed middleware did not check LicensingEnabled,
so feed endpoints responded with valid data even when the feature was
disabled. Now checks the effective config (repo → org cascade) and
returns 404 when neither level has LicensingEnabled=true.

Co-Authored-By: Moko Consulting <hello@mokoconsulting.tech>
jmiller merged commit 2c394870de into main 2026-06-11 21:12:45 +00:00
jmiller deleted branch fix/589-feed-disabled-check 2026-06-11 21:12:46 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
No labels
Priority -
Type -
Status —
Priority —
Type —
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#599
Delete Branch "fix/589-feed-disabled-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?