fix: update server feed generation bugs (#601) #605

Merged

jmiller merged 2 commits from fix/601-update-feed-bugs into main 2026-06-11 21:37:54 +00:00

Conversation 0 Commits 2 Files Changed 1

+30 -19

jmiller commented 2026-06-11 21:28:50 +00:00

Owner

Copy Link

Copy Source

Summary

Fixes four bugs in services/updateserver/joomla.go affecting Joomla update feed correctness.

Changes

1. Default targetplatform: (5|6)\\..* → 6\\..* — Joomla 6 sites couldn't match the old pattern
2. FullElementName(): Use auto-construction from PackageType + Name when no explicit override is set
3. <client> numeric values: "site"/"administrator" → "0"/"1" — PHP casts strings to 0, breaking admin extension matching
4. Pre-release suffix preserved: v1.2.3-rc2 now stays 1.2.3-rc2 instead of becoming 1.2.3-rc

Closes #601

## Summary Fixes four bugs in `services/updateserver/joomla.go` affecting Joomla update feed correctness. ## Changes 1. **Default `targetplatform`**: `(5|6)\\..*` → `6\\..*` — Joomla 6 sites couldn't match the old pattern 2. **`FullElementName()`**: Use auto-construction from `PackageType` + `Name` when no explicit override is set 3. **`<client>` numeric values**: `"site"`/`"administrator"` → `"0"`/`"1"` — PHP casts strings to `0`, breaking admin extension matching 4. **Pre-release suffix preserved**: `v1.2.3-rc2` now stays `1.2.3-rc2` instead of becoming `1.2.3-rc` Closes #601

jmiller added 1 commit 2026-06-11 21:28:52 +00:00

fix: update server feed generation bugs (#601) ... 7dfb11070d

- Change default targetplatform from (5|6)\.* to 6\..* for Joomla 6 compat
- Use FullElementName() to auto-construct element from PackageType + Name
- Change <client> from string (site/administrator) to numeric (0/1)
- Preserve pre-release version suffix number (e.g. -rc2 not just -rc)

Co-Authored-By: Moko Consulting <hello@mokoconsulting.tech>

jmiller added 1 commit 2026-06-11 21:36:55 +00:00

fix: address review findings for update feed bugs ... 878cac5d99

- Extend versionRegex to capture pre-release suffixes in fallback path
- Anchor versionHasChannelSuffix with regex to avoid false positives
- Log LoadAttributes errors instead of silently skipping releases

jmiller merged commit ea77b253a9 into main 2026-06-11 21:37:54 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

breaking-change

Breaking API or behavior change

ci-cd

CI/CD pipeline changes

config

Configuration changes

dependencies

Dependency updates

deploy-failure

Deployment failed

docker

Docker/container changes

documentation

Documentation changes

good first issue

Good for newcomers

health-check

Repo health check result

help wanted

Extra attention needed

mokostandards

Related to MokoStandards framework

push-failure

Git push operation failed

security

Security vulnerability or hardening

size/l

200-500 lines changed

size/m

50-200 lines changed

size/s

10-50 lines changed

size/xl

500+ lines changed

size/xs

< 10 lines changed

standards-drift

Deviates from MokoStandards

standards-update

MokoStandards compliance update

sync-failure

Sync or mirror failed

tech-debt

Technical debt and TODO/FIXME items

upstream

upstream

Inherited from upstream Gitea

work-in-progress

Draft or incomplete work

No labels

Priority -

Type -

Status —

Priority —

Type —

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-APP#605