MokoConsulting/MokoGitea-Fork
1
0
Fork 0
Code Issues 123 Pull Requests Releases 96 Wiki Activity

fix: use string client values per Joomla update spec #611

Closed
jmiller wants to merge 0 commits from fix/client-tag-strings into main
pull from: fix/client-tag-strings
merge into: :main
Conversation 1 Commits - Files Changed -
jmiller commented 2026-06-12 00:32:19 +00:00
Owner
Copy Link
Copy Source

Reverts client tag from numeric 0/1 to string site/administrator per Joomla update server spec.

Reverts client tag from numeric 0/1 to string site/administrator per Joomla update server spec.
jmiller added 1 commit 2026-06-12 00:32:21 +00:00
fix: use string client values (site/administrator) per Joomla update spec
Universal: Auto Version Bump / Version Bump (push) Successful in 7s
Details
Generic: Repo Health / Site Health (push) Has been skipped
Details
Generic: Repo Health / Access control (push) Successful in 3s
Details
Branch Policy Check / Verify merge target (pull_request) Failing after 1s
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Universal: PR Check / Validate PR (pull_request) Failing after 10s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 27s
Details
PR RC Release / Build RC Release (pull_request) Failing after 1m28s
Details
Universal: Secret Scanning / Gitleaks Secret Scan (pull_request) Successful in 55s
Details
Generic: Repo Health / Scripts governance (push) Has been cancelled
Details
Generic: Repo Health / Repository health (push) Has been cancelled
Details
Generic: Repo Health / Report Issues (push) Has been cancelled
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report Issues (pull_request) Has been cancelled
Details
Branch Cleanup / Delete merged branch (pull_request) Has been skipped
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
c2687a2595 
Joomla's update server documentation specifies <client> should be
"site" or "administrator" strings, not numeric 0/1. Joomla's XML
parser handles the string-to-integer mapping internally.

Co-Authored-By: Moko Consulting <hello@mokoconsulting.tech>
jmiller closed this pull request 2026-06-12 00:32:33 +00:00
jmiller deleted branch fix/client-tag-strings 2026-06-12 00:32:34 +00:00
jmiller reopened this pull request 2026-06-12 00:33:02 +00:00
jmiller closed this pull request 2026-06-14 03:01:13 +00:00
jmiller deleted branch fix/client-tag-strings 2026-06-14 03:01:14 +00:00
jmiller commented 2026-06-14 17:45:47 +00:00
Author
Owner
Copy Link
Copy Source

Critical: <client> tag breaks package update detection in Joomla 6

Root Cause (traced through Joomla 6.1.1 source)

ExtensionAdapter.php line 62 — when parsing the update XML feed, the default client_id is hardcoded to 1 (administrator):

$this->currentUpdate->client_id = 1;

ExtensionAdapter.php lines 308-318 — the <client> tag is resolved:

  • <client>administrator</client> → client_id = 1
  • <client>site</client> → client_id = 0
  • Omitted → defaults to client_id = 1

PackageAdapter.php line 548 — packages are always stored with client_id = 0:

$this->extension->client_id = 0;

Updater.php lines 362-380 — the update finder matches by exact (element, type, client_id, folder):

$eid = $extension->find([
    'element'   => $current_update->element,
    'type'      => $current_update->type,
    'client_id' => $current_update->client_id,
    'folder'    => $current_update->folder ?? '',
]);

The Problem

The MokoGitea feed generator emits <client>administrator</client> for ALL extensions including packages. This causes:

  1. Feed parsed → client_id = 1 in #__updates
  2. Package stored → client_id = 0 in #__extensions
  3. Updater match → 1 != 0 → extension_id stays 0
  4. UI → update never shows

Required Fix

Extension Type <client> value client_id
component administrator 1
package site 0
plugin site 0
module (admin) administrator 1
module (site) site 0
library site 0
file site 0

Affected

pkg_mokosuitehq confirmed — updates never show despite valid feed. Potentially ALL package-type extensions using MokoGitea update feeds.

## Critical: `<client>` tag breaks package update detection in Joomla 6 ### Root Cause (traced through Joomla 6.1.1 source) **`ExtensionAdapter.php` line 62** — when parsing the update XML feed, the default `client_id` is hardcoded to `1` (administrator): ```php $this->currentUpdate->client_id = 1; ``` **`ExtensionAdapter.php` lines 308-318** — the `<client>` tag is resolved: - `<client>administrator</client>` → `client_id = 1` - `<client>site</client>` → `client_id = 0` - **Omitted** → defaults to `client_id = 1` **`PackageAdapter.php` line 548** — packages are always stored with `client_id = 0`: ```php $this->extension->client_id = 0; ``` **`Updater.php` lines 362-380** — the update finder matches by exact `(element, type, client_id, folder)`: ```php $eid = $extension->find([ 'element' => $current_update->element, 'type' => $current_update->type, 'client_id' => $current_update->client_id, 'folder' => $current_update->folder ?? '', ]); ``` ### The Problem The MokoGitea feed generator emits `<client>administrator</client>` for ALL extensions including packages. This causes: 1. Feed parsed → `client_id = 1` in `#__updates` 2. Package stored → `client_id = 0` in `#__extensions` 3. Updater match → `1 != 0` → `extension_id` stays `0` 4. UI → update never shows ### Required Fix | Extension Type | `<client>` value | `client_id` | |---|---|---| | component | `administrator` | 1 | | package | `site` | 0 | | plugin | `site` | 0 | | module (admin) | `administrator` | 1 | | module (site) | `site` | 0 | | library | `site` | 0 | | file | `site` | 0 | ### Affected `pkg_mokosuitehq` confirmed — updates never show despite valid feed. Potentially ALL package-type extensions using MokoGitea update feeds.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
breaking-change
Breaking API or behavior change
 ci-cd
CI/CD pipeline changes
 config
Configuration changes
 dependencies
Dependency updates
 deploy-failure
Deployment failed
 docker
Docker/container changes
 documentation
Documentation changes
 feature: wiki
Wiki system enhancements
 good first issue
Good for newcomers
 health-check
Repo health check result
 help wanted
Extra attention needed
 mokostandards
Related to MokoStandards framework
 push-failure
Git push operation failed
 security
Security vulnerability or hardening
 size/l
200-500 lines changed
 size/m
50-200 lines changed
 size/s
10-50 lines changed
 size/xl
500+ lines changed
 size/xs
< 10 lines changed
 standards-drift
Deviates from MokoStandards
 standards-update
MokoStandards compliance update
 sync-failure
Sync or mirror failed
 tech-debt
Technical debt and TODO/FIXME items
 upstream
upstream
Inherited from upstream Gitea
 work-in-progress
Draft or incomplete work
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller) moko-deploy (Moko Deploy Bot)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoGitea-Fork#611
Delete Branch "fix/client-tag-strings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?