fix: repair build (renamed org-visibility helper) + gofmt #735

2026-07-05T05:07:34Z

jmiller commented

2026-07-05 05:07:34 +00:00

The fork's server binary doesn't currently go build — found when I compiled the org-governance series locally with a real toolchain (go1.26.3) for the first time.

routers/api/v1/api.go:519 calls organization.HasOrgOrUserVisible, which no longer exists — it was renamed to IsOwnerVisibleToDoer (models/organization/org.go:548, identical signature (ctx, orgOrUser, user *User) bool). This one missed call site fails compilation of the whole routers/api/v1 package. This is pre-existing on main (byte-identical), not from #727.
gofmt: api.go (a mis-indented commented-out /projects block) and release.go (import sort) were gofmt-dirty; fixed with gofmt -w on the two files this change touches.

Verified locally

go build ./... → clean (was failing before the rename).
gofmt -l on all changed files → clean.
go vet ./... running.

Merging this makes dev (and, via #733, main) actually buildable. CI's Lint & Validate never caught this because it doesn't run a full go build.

https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT

**The fork's server binary doesn't currently `go build`** — found when I compiled the org-governance series locally with a real toolchain (go1.26.3) for the first time. - `routers/api/v1/api.go:519` calls `organization.HasOrgOrUserVisible`, which **no longer exists** — it was renamed to `IsOwnerVisibleToDoer` (`models/organization/org.go:548`, identical signature `(ctx, orgOrUser, user *User) bool`). This one missed call site fails compilation of the whole `routers/api/v1` package. This is **pre-existing on `main`** (byte-identical), not from #727. - **gofmt:** `api.go` (a mis-indented commented-out `/projects` block) and `release.go` (import sort) were gofmt-dirty; fixed with `gofmt -w` on the two files this change touches. ## Verified locally - `go build ./...` → **clean** (was failing before the rename). - `gofmt -l` on all changed files → **clean**. - `go vet ./...` running. Merging this makes `dev` (and, via #733, `main`) actually buildable. CI's Lint & Validate never caught this because it doesn't run a full `go build`. https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT

jmiller added 1 commit 2026-07-05 05:07:38 +00:00

fix: repair build (renamed org-visibility helper) + gofmt

Universal: PR Check / Branch Policy (pull_request) Successful in 3s

Details

PR RC Release / Build RC Release (pull_request) Successful in 4s

Details

Universal: PR Check / Validate PR (pull_request) Successful in 19s

Details

RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped

Details

Branch Cleanup / Delete merged branch (pull_request) Successful in 2s

Details

Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 1m8s

Details

Generic: Project CI / Lint & Validate (pull_request) Successful in 1m10s

Details

Universal: PR Check / Secret Scan (pull_request) Successful in 2m43s

Details

Generic: Project CI / Tests (pull_request) Has been cancelled

Details

Universal: PR Check / Build RC Package (pull_request) Has been cancelled

Details

Universal: PR Check / Report Issues (pull_request) Has been cancelled

Details

125eefc650

Two pre-existing issues surfaced when the org-governance series was compiled
locally with a real Go toolchain (go1.26.3) for the first time:

- routers/api/v1/api.go:519 called organization.HasOrgOrUserVisible, which no
  longer exists — it was renamed to IsOwnerVisibleToDoer (models/organization/
  org.go:548, identical signature). This one missed call site meant the whole
  routers/api/v1 package (and therefore the server binary) failed `go build`.
  With the rename, `go build ./...` is clean.
- gofmt: api.go (a mis-indented commented-out /projects route block) and
  release.go (import sort: repo before updateserver) were gofmt-dirty. Fixed
  with gofmt -w on the two files this change already touches.

Not part of #727, but blocks building/releasing the fork; found while validating
the dev -> main promotion (#733).

Claude-Session: https://claude.ai/code/session_01Wsno14cxE49MstXFs9G5KT

jmiller merged commit 63f773aa56 into dev

2026-07-05 05:08:11 +00:00

jmiller deleted branch fix/compile-hasorgvisible-and-gofmt

2026-07-05 05:08:11 +00:00

jmiller referenced this issue from a commit

2026-07-05 07:01:04 +00:00

docs: README org-governance feature + CHANGELOG CI fixes (#727)

jmiller referenced this pull request

2026-07-05 07:01:31 +00:00

docs(api): OpenAPI spec + README/CHANGELOG for org-governance (#727, #738) #739

Sign in to join this conversation.