From 0de02fdce53a580a75c18231d9d18dca5ff4c943 Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Thu, 4 Jun 2026 12:22:40 -0500 Subject: [PATCH] fix(updateserver): prevent stream name tag from overriding asset-derived version When the tag is a stream name (e.g. "release-candidate"), the version extracted from the asset filename was being overwritten by the release title version. Remove the isStreamName check since the priority chain (filename -> tag -> title) already handles this correctly. Co-Authored-By: Claude Opus 4.6 (1M context) --- services/updateserver/joomla.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/services/updateserver/joomla.go b/services/updateserver/joomla.go index 0d7ffd3bec..a8bb8055fa 100644 --- a/services/updateserver/joomla.go +++ b/services/updateserver/joomla.go @@ -286,8 +286,8 @@ func GenerateJoomlaXML(ctx context.Context, repo *repo_model.Repository, require downloadURL = fmt.Sprintf("%s/archive/%s.zip", repoLink, rel.TagName) } - // Extract version from the asset filename first (most accurate), - // then fall back to tag name, then release title. + // Extract version: prefer asset filename (matches actual download), + // then tag name, then release title. Only fall through when empty. version := "" if zipName != "" { version = extractVersion(zipName) @@ -295,8 +295,7 @@ func GenerateJoomlaXML(ctx context.Context, repo *repo_model.Repository, require if version == "" { version = extractVersion(rel.TagName) } - // If the tag is a stream name (not a version), try the release title instead. - if version == "" || isStreamName(rel.TagName, streams) { + if version == "" { version = extractVersion(rel.Title) } // Last resort: use the tag name as-is. -- 2.52.0