From 635a13d277f9bb774dd666117c47d70fb55ce12a Mon Sep 17 00:00:00 2001 From: Jonathan Miller Date: Thu, 4 Jun 2026 16:33:04 -0500 Subject: [PATCH] fix(updateserver): only show downloadkey when downloads are gated Show only when download_gating is prerelease or all. No gating means no license keys are needed, so don't prompt for one. Co-Authored-By: Claude Opus 4.6 (1M context) --- routers/web/repo/updateserver.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/routers/web/repo/updateserver.go b/routers/web/repo/updateserver.go index 29a6b77355..3e9418051a 100644 --- a/routers/web/repo/updateserver.go +++ b/routers/web/repo/updateserver.go @@ -94,9 +94,9 @@ func ServeUpdatesXML(ctx *context.Context) { } repoCfg, _ := licenses.GetRepoConfig(ctx, ctx.Repo.Repository.ID) - // Show when licensing is enabled (prepares Joomla to accept keys) - // or when require_key is explicitly set. - requireKey := repoCfg != nil && (repoCfg.LicensingEnabled || repoCfg.RequireKey) + // Show only when downloads are gated (prerelease or all). + // No gating = no license keys needed = no downloadkey element. + requireKey := repoCfg != nil && repoCfg.DownloadGating != "" && repoCfg.DownloadGating != "none" xmlData, err := updateserver.GenerateJoomlaXML(ctx, ctx.Repo.Repository, requireKey, stripDownloads, allowedChannels...) if err != nil { -- 2.52.0