MokoConsulting/MokoJoomTOS
1
0
Fork 0
Code Issues 20 Pull Requests Releases 3 Wiki Activity

bug: missing asset_id and params in article creation data #94

New Issue
Closed
opened 2026-05-22 03:29:51 +00:00 by jmiller · 1 comment
jmiller commented 2026-05-22 03:29:51 +00:00
Owner
Copy Link
Copy Source

Description

The $data array in createTermsArticle() (script.php:217-228) is missing asset_id, params, metadata, and attribs fields. Joomla's ContentTable::store() attempts to create an asset record which may fail on strict Joomla 5 installs if these fields are absent.

Impact

Article may be stored without ACL protection, or check() may fail silently on some Joomla configurations.

Fix

Add default values for params, metadata, attribs to the data array.

Files

  • src/script.php:217-228
## Description The `$data` array in `createTermsArticle()` (script.php:217-228) is missing `asset_id`, `params`, `metadata`, and `attribs` fields. Joomla's `ContentTable::store()` attempts to create an asset record which may fail on strict Joomla 5 installs if these fields are absent. ## Impact Article may be stored without ACL protection, or `check()` may fail silently on some Joomla configurations. ## Fix Add default values for `params`, `metadata`, `attribs` to the data array. ## Files - `src/script.php:217-228`
jmiller added the joomlapriority: highbug labels 2026-05-22 03:29:51 +00:00
jmiller commented 2026-05-22 03:38:43 +00:00
Author
Owner
Copy Link
Copy Source

Testing Steps -- Article creation with params/metadata defaults

Setup

  1. Fresh Joomla 5.x install with debug mode enabled and error reporting = Maximum

Test

  1. Install the plugin (fresh, no existing Terms of Service article)
  2. Check the Joomla debug console for any warnings about missing fields
  3. Go to Content > Articles > Terms of Service -- open the article
  4. Click the Publishing tab -- verify metadata fields are present and editable
  5. Click the Options tab -- verify article display options are present
  6. Expected: No PHP notices about undefined indices or missing properties

Pass criteria

  • Article created without PHP warnings
  • Article metadata and options tabs work correctly in admin
## Testing Steps -- Article creation with params/metadata defaults ### Setup 1. Fresh Joomla 5.x install with **debug mode enabled** and **error reporting = Maximum** ### Test 1. Install the plugin (fresh, no existing Terms of Service article) 2. Check the Joomla debug console for any warnings about missing fields 3. Go to **Content > Articles > Terms of Service** -- open the article 4. Click the **Publishing** tab -- verify metadata fields are present and editable 5. Click the **Options** tab -- verify article display options are present 6. **Expected:** No PHP notices about undefined indices or missing properties ### Pass criteria - [ ] Article created without PHP warnings - [ ] Article metadata and options tabs work correctly in admin
Sign in to join this conversation.
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 bug
Something is broken
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 code-quality
Code standards and cleanup
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 enhancement
New feature or improvement
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 major-release
Major version release (breaking changes)
 minor-release
Minor version release (XX.YY.00)
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 needs-testing
Requires manual or automated testing
 patch-release
Patch version release (XX.YY.ZZ)
 pending: testing
Closed without testing proof - needs verification before closing
 php
PHP code changes
 priority: critical
Must fix before any release
 priority: critical
Critical priority, must be addressed immediately
 priority: high
High priority
 priority: high
Should fix soon
 priority: low
Low priority
 priority: low
Nice to have
 priority: medium
Medium priority
 priority: medium
Fix when convenient
 push-failure
File push failure requiring attention
 python
Python code changes
 regression
Regression from a previous working state
 release-candidate
Release candidate build
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 standards-violation
Standards compliance failure
 status: blocked
Blocked by another issue or dependency
 status: in-progress
Currently being worked on
 status: needs-review
Awaiting code review
 status: on-hold
Temporarily on hold
 status: pending
Pending action or decision
 status: wontfix
This will not be worked on
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 test-failure
Automated test failure
 testing
Manual testing tasks
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: release
Release preparation or tracking
 type: test
Test suite additions or changes
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-branch
Version branch related
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels bug joomla priority: high
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoJoomTOS#94
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?