MokoConsulting/MokoOnyx
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases 2 Activity

bug: site.webmanifest 404 — favicon generator not creating manifest #1

New Issue
Open
opened 2026-04-22 03:15:41 +00:00 by jmiller · 0 comments
jmiller commented 2026-04-22 03:15:41 +00:00
Owner
Copy Link

Problem

<link rel="manifest" href="/images/favicons/site.webmanifest"> returns 404.

The getHeadTags() method in helper/favicon.php always outputs the manifest <link> tag, but site.webmanifest is only created when generateManifest() runs successfully during favicon generation.

Possible causes

  1. No favicon source configured in template params (favicon_source)
  2. Favicon generation failed silently (GD/Imagick not available)
  3. The images/favicons/ directory doesn't exist or isn't writable
  4. Stamp file prevents regeneration even though manifest is missing

Expected behaviour

  • If no favicon source is set, don't output the manifest <link> tag
  • If favicon generation fails, don't output <link> tags for missing files
  • Consider checking file existence before outputting each <link> tag

Files

  • src/helper/favicon.php — generateManifest() (line 477), getHeadTags() (line 494)
## Problem `<link rel="manifest" href="/images/favicons/site.webmanifest">` returns 404. The `getHeadTags()` method in `helper/favicon.php` always outputs the manifest `<link>` tag, but `site.webmanifest` is only created when `generateManifest()` runs successfully during favicon generation. ## Possible causes 1. No favicon source configured in template params (`favicon_source`) 2. Favicon generation failed silently (GD/Imagick not available) 3. The `images/favicons/` directory doesn't exist or isn't writable 4. Stamp file prevents regeneration even though manifest is missing ## Expected behaviour - If no favicon source is set, don't output the manifest `<link>` tag - If favicon generation fails, don't output `<link>` tags for missing files - Consider checking file existence before outputting each `<link>` tag ## Files - `src/helper/favicon.php` — `generateManifest()` (line 477), `getHeadTags()` (line 494)
jmiller self-assigned this 2026-04-22 03:15:41 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 priority: critical
Critical priority, must be addressed immediately
 priority: high
High priority
 priority: low
Low priority
 priority: medium
Medium priority
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 status: blocked
Blocked by another issue or dependency
 status: in-progress
Currently being worked on
 status: on-hold
Temporarily on hold
 status: pending
Pending action or decision
 status: wontfix
This will not be worked on
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller
No Assignees jmiller
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoOnyx#1
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?