bug: missing closing div in backups/default.php restore modal (line ~451) #177

New Issue

2026-06-29T14:22:16Z

jmiller commented

2026-06-29 14:22:16 +00:00

Summary

The restore modal markup in tmpl/backups/default.php is missing a closing </div> tag around line 451. This causes the modal structure to be malformed, which can break Bootstrap 5 modal behavior depending on how the browser resolves the unclosed element.

Location

tmpl/backups/default.php — approximately line 451, inside the restore modal's modal-body section. The opening <div class="modal-body"> doesn't have a matching close before the <div class="modal-footer">.

What to do

Audit the restore modal HTML structure (starts around line 450) and add the missing </div>
Verify the modal opens, displays progress, and closes correctly after the fix

Why

Unclosed HTML elements cause unpredictable browser rendering. In this case it may shift the modal footer inside the body, breaking the sticky footer layout.

## Summary The restore modal markup in `tmpl/backups/default.php` is missing a closing `</div>` tag around line 451. This causes the modal structure to be malformed, which can break Bootstrap 5 modal behavior depending on how the browser resolves the unclosed element. ## Location `tmpl/backups/default.php` — approximately line 451, inside the restore modal's `modal-body` section. The opening `<div class="modal-body">` doesn't have a matching close before the `<div class="modal-footer">`. ## What to do - [ ] Audit the restore modal HTML structure (starts around line 450) and add the missing `</div>` - [ ] Verify the modal opens, displays progress, and closes correctly after the fix ## Why Unclosed HTML elements cause unpredictable browser rendering. In this case it may shift the modal footer inside the body, breaking the sticky footer layout.

jmiller added the component: admin label 2026-06-29 14:22:16 +00:00

jmiller commented

2026-06-29 14:22:20 +00:00

Branch created: feature/177-bug-missing-closing-div-in-backups-defau

git fetch origin
git checkout feature/177-bug-missing-closing-div-in-backups-defau

Branch created: [`feature/177-bug-missing-closing-div-in-backups-defau`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/177-bug-missing-closing-div-in-backups-defau) ```bash git fetch origin git checkout feature/177-bug-missing-closing-div-in-backups-defau ```

jmiller commented

2026-07-05 19:46:23 +00:00

Confirmed @ 02.56.05 — keep open, with a small correction.

The restore modal in tmpl/backups/default.php (opens line 399: modal → modal-dialog 400 → modal-content 401 → form 406) is missing one closing </div>: after </form> (450) only modal-content (451) and modal (452) close — the modal-dialog </div> is absent. (The issue text says "modal-body", but modal-body is correctly closed at 441; the unclosed element is modal-dialog.) Contrast the well-formed progress modal at 455-470. Fix: add one </div>.

Confirmed @ 02.56.05 — keep open, with a small correction. The restore modal in `tmpl/backups/default.php` (opens line 399: `modal` → `modal-dialog` 400 → `modal-content` 401 → `form` 406) is missing one closing `</div>`: after `</form>` (450) only `modal-content` (451) and `modal` (452) close — the **`modal-dialog`** `</div>` is absent. (The issue text says "modal-body", but modal-body is correctly closed at 441; the unclosed element is `modal-dialog`.) Contrast the well-formed progress modal at 455-470. Fix: add one `</div>`.

Sign in to join this conversation.

Priority Medium

Type Feature

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#177