fix: CLI snapshot delete uses file_path instead of data_file column #184

New Issue

2026-06-29T14:40:15Z

jmiller commented

2026-06-29 14:40:15 +00:00

Summary

SnapshotCommand.php:230-234 references $record->file_path when the actual DB column is data_file. The CLI mokosuitebackup:snapshot delete silently skips file deletion, leaving orphaned JSON files on disk.

Location

source/packages/plg_console_mokosuitebackup/src/Command/SnapshotCommand.php:230-234

Fix

Change $record->file_path to $record->data_file.

## Summary `SnapshotCommand.php:230-234` references `$record->file_path` when the actual DB column is `data_file`. The CLI `mokosuitebackup:snapshot delete` silently skips file deletion, leaving orphaned JSON files on disk. ## Location `source/packages/plg_console_mokosuitebackup/src/Command/SnapshotCommand.php:230-234` ## Fix Change `$record->file_path` to `$record->data_file`.

jmiller commented

2026-06-29 14:40:18 +00:00

Branch created: feature/184-fix-cli-snapshot-delete-uses-file-path-i

git fetch origin
git checkout feature/184-fix-cli-snapshot-delete-uses-file-path-i

Branch created: [`feature/184-fix-cli-snapshot-delete-uses-file-path-i`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteBackup/src/branch/feature/184-fix-cli-snapshot-delete-uses-file-path-i) ```bash git fetch origin git checkout feature/184-fix-cli-snapshot-delete-uses-file-path-i ```

jmiller commented

2026-07-05 19:46:41 +00:00

Confirmed @ 02.56.05 — keep open.

plg_console_mokosuitebackup/src/Command/SnapshotCommand.php:230-234 still references $record->file_path, but the snapshots table column is data_file (sql/install.mysql.sql:75 — data_file VARCHAR(512), "Absolute path to JSON snapshot file"). There is no file_path column, so is_file($record->file_path) is always empty and file deletion is silently skipped. One-line fix: use data_file.

Confirmed @ 02.56.05 — keep open. `plg_console_mokosuitebackup/src/Command/SnapshotCommand.php:230-234` still references `$record->file_path`, but the snapshots table column is `data_file` (`sql/install.mysql.sql:75` — `data_file VARCHAR(512)`, "Absolute path to JSON snapshot file"). There is no `file_path` column, so `is_file($record->file_path)` is always empty and file deletion is silently skipped. One-line fix: use `data_file`.

jmiller referenced this issue from a commit

2026-07-05 21:31:27 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 21:31:47 +00:00

fix: security + data-integrity fixes (P0/P1) #211

jmiller referenced this issue from a commit

2026-07-05 21:33:12 +00:00

fix: security + data-integrity fixes (P0/P1)

jmiller referenced this issue

2026-07-05 22:06:17 +00:00

docs(changelog): backfill 02.56.07 + 02.56.08 (shipped with empty changelogs) #215