Apply standard licensing + install-completion installer script pattern #202

Merged

jmiller merged 1 commits from chore/installer-script-template into main 2026-07-04 20:27:27 +00:00

Conversation 0 Commits 1 Files Changed 1

+56 -61

jmiller commented 2026-07-04 19:34:57 +00:00

Owner

Copy Link

Copy Source

Summary

Applies the Template-Joomla/samples/script/script_package.php pattern to source/script.php for download-key handling and install completion, while preserving every MokoSuiteBackup-specific postflight step (plugin enable, webcron secret, default scheduled task, submenu items, client_id fix, icon sync, backup_dir migration, review-settings notice).

Licensing / key handling

• preflight (update) → backupDownloadKey() caches the bare dlid value from the update site.
• postflight (update) → restoreDownloadKey() re-writes extra_query as dlid=<key> on the (possibly re-registered) update site.
• Placeholders resolved: {REPONAME}→MokoSuiteBackup, {PACKAGENAME}→pkg_mokosuitebackup.
• Licensing methods now log via Joomla\CMS\Log\Log instead of error_log.

Install completion

• installSuccessful() info notice shows on install and update.
• warnMissingLicenseKey() prompt shows on install only — a fresh install never carries a key, so the previous always-run "is a key already present?" guard is removed.

Notes

• preflight_saveKey() was renamed to backupDownloadKey() (now private) per the template.
• Independent branch off main; does not overlap the branding (#200) or manifest (#201) PRs.

Test plan

• Fresh install → "installed successfully" + "License Key Required" notices; default profile created.
• Enter a DLID, then update → key preserved (no re-entry needed), "installed successfully" shows, no license nag.
• php -l passes (verified locally).

## Summary Applies the `Template-Joomla/samples/script/script_package.php` pattern to `source/script.php` for **download-key handling** and **install completion**, while preserving every MokoSuiteBackup-specific postflight step (plugin enable, webcron secret, default scheduled task, submenu items, `client_id` fix, icon sync, `backup_dir` migration, review-settings notice). ### Licensing / key handling - `preflight` (update) → `backupDownloadKey()` caches the bare `dlid` value from the update site. - `postflight` (update) → `restoreDownloadKey()` re-writes `extra_query` as `dlid=<key>` on the (possibly re-registered) update site. - Placeholders resolved: `{REPONAME}`→`MokoSuiteBackup`, `{PACKAGENAME}`→`pkg_mokosuitebackup`. - Licensing methods now log via `Joomla\CMS\Log\Log` instead of `error_log`. ### Install completion - `installSuccessful()` info notice shows on **install and update**. - `warnMissingLicenseKey()` prompt shows on **install only** — a fresh install never carries a key, so the previous always-run "is a key already present?" guard is removed. ## Notes - `preflight_saveKey()` was renamed to `backupDownloadKey()` (now private) per the template. - Independent branch off `main`; does not overlap the branding (#200) or manifest (#201) PRs. ## Test plan - [ ] Fresh install → "installed successfully" + "License Key Required" notices; default profile created. - [ ] Enter a DLID, then update → key preserved (no re-entry needed), "installed successfully" shows, no license nag. - [ ] `php -l` passes (verified locally).

jmiller added 1 commit 2026-07-04 20:27:15 +00:00

fix(installer): apply standard licensing + install-completion script pattern ... 1758694893

Adopts the Template-Joomla package-script pattern for download-key handling
and post-install messaging, while preserving all MokoSuiteBackup-specific
postflight steps (plugins, webcron secret, scheduled task, submenus,
client_id fix, icon sync, backup_dir migration).

- preflight (update): backupDownloadKey() caches the bare dlid value
- postflight (update): restoreDownloadKey() re-writes extra_query as dlid=<key>
- postflight (install): installSuccessful() + warnMissingLicenseKey()
- postflight (update): installSuccessful()
- License nag now runs on install only (a fresh install never has a key),
  removing the previous always-run "is a key present?" guard
- Licensing methods log via Joomla\CMS\Log\Log instead of error_log

jmiller force-pushed chore/installer-script-template from 3ec56906a3 to 1758694893 2026-07-04 20:27:15 +00:00 Compare

jmiller merged commit 23fa4884bd into main 2026-07-04 20:27:27 +00:00

jmiller deleted branch chore/installer-script-template 2026-07-04 20:27:29 +00:00

jmiller referenced this pull request 2026-07-04 20:54:44 +00:00

docs(changelog): document 02.53.00–02.55.00 releases #205

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

component: admin

Admin UI and views

component: api

REST API

component: engine

Backup/restore engine

component: remote

Remote storage (FTP/GDrive)

component: scheduler

Scheduled tasks

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Priority -

Type -

Milestone

No items

No Milestone

Assignees

Clear assignees

jmiller (Jonathan Miller)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#202