MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 28 Pull Requests Releases 2 Wiki Activity

fix(plugin): pre-update backup notifies on success, not only failure #221

Merged
jmiller merged 2 commits from fix/preupdate-notification into dev 2026-07-05 23:58:24 +00:00
Conversation 0 Commits 2 Files Changed 15
+35 -15
jmiller commented 2026-07-05 23:58:02 +00:00
Owner
Copy Link
Copy Source

Targeting dev.

Why "the pre-update popup notification isn't firing": runPreActionBackup() only called enqueueMessage() when the backup failed. On a successful pre-update backup it was completely silent — so nothing appeared.

Fix: surface every outcome using the BackupRunner status:

  • complete → success notice ("Pre-update backup completed successfully.")
  • warning → warning (local archive made, remote upload failed)
  • fail / exception → error

Now a pre-update backup always produces an admin notification. php -l clean.

Note on a progress popup

This is the notification (admin message banner). A live progress modal during the extension update — like "Backup Now" on the dashboard — is a separate, harder piece (#196): the update runs server-side in one request and can't drive the AJAX progress modal without injecting into com_installer's page. If you want that too, it's a bigger change; this PR makes the outcome visible in the meantime.

Also — confirm "Backup before update" is enabled in the component options; if it's off, runPreActionBackup() returns before doing anything.

https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i

Targeting **dev**. **Why "the pre-update popup notification isn't firing":** `runPreActionBackup()` only called `enqueueMessage()` when the backup **failed**. On a successful pre-update backup it was completely silent — so nothing appeared. **Fix:** surface every outcome using the `BackupRunner` status: - `complete` → success notice ("Pre-update backup completed successfully.") - `warning` → warning (local archive made, remote upload failed) - `fail` / exception → error Now a pre-update backup always produces an admin notification. `php -l` clean. ## Note on a *progress* popup This is the notification (admin message banner). A live **progress modal** during the extension update — like "Backup Now" on the dashboard — is a separate, harder piece (#196): the update runs server-side in one request and can't drive the AJAX progress modal without injecting into com_installer's page. If you want that too, it's a bigger change; this PR makes the outcome visible in the meantime. Also — confirm **"Backup before update"** is enabled in the component options; if it's off, `runPreActionBackup()` returns before doing anything. https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller added 1 commit 2026-07-05 23:58:03 +00:00
fix(plugin): pre-update backup notifies on success too, not only failure
Universal: PR Check / Require Docs Update (pull_request) Has been skipped
Details
Universal: PR Check / Wiki Update Reminder (pull_request) Has been skipped
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 3s
Details
Generic: Project CI / Lint & Validate (pull_request) Successful in 17s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 12s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 44s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 1m5s
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 1m13s
Details
Generic: Project CI / Tests (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
1a1c81550c 
runPreActionBackup() only enqueued a message when the backup failed, so a
successful pre-update backup produced no admin notification at all. Now it
surfaces every outcome via the BackupRunner status: complete -> success,
warning (archive made but remote upload failed) -> warning, fail -> error.

Refs #192

Claude-Session: https://claude.ai/code/session_01WbGBN9VyRK61zczYWcCQ2i
jmiller added 1 commit 2026-07-05 23:58:18 +00:00
chore(version): pre-release bump to 02.57.09-dev [skip ci]
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 3s
Details
dfd4e77ade
jmiller merged commit e1f5afb301 into dev 2026-07-05 23:58:24 +00:00
jmiller deleted branch fix/preupdate-notification 2026-07-05 23:58:26 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#221
Delete Branch "fix/preupdate-notification"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?