MokoConsulting/MokoSuiteBackup
1
0
Fork 0
Code Issues 18 Pull Requests Packages Releases 5 Wiki Activity

fix: SFTP fields not showing when SFTP selected #95

Merged
jmiller merged 3 commits from fix/sftp-showon into main 2026-06-23 13:32:55 +00:00
Conversation 0 Commits 3 Files Changed 10
+72 -73
jmiller commented 2026-06-23 13:29:23 +00:00
Owner
Copy Link
Copy Source

Summary

SFTP fields were in a separate <fieldset name="sftp"> which renders as a different tab in Joomla's admin UI. Joomla's showon JavaScript only searches within the same rendered DOM container, so it couldn't find the remote_storage dropdown to toggle visibility.

Fix: Moved all SFTP fields into the remote fieldset (same fieldset as the remote_storage dropdown). The showon="remote_storage:sftp" attribute now works correctly.

Test Plan

  • Edit profile → select SFTP → fields appear (host, port, username, password, key, passphrase, path)
  • Select FTP → FTP fields appear, SFTP fields hide
  • Select None → all remote fields hide
## Summary SFTP fields were in a separate `<fieldset name="sftp">` which renders as a different tab in Joomla's admin UI. Joomla's `showon` JavaScript only searches within the same rendered DOM container, so it couldn't find the `remote_storage` dropdown to toggle visibility. **Fix**: Moved all SFTP fields into the `remote` fieldset (same fieldset as the `remote_storage` dropdown). The `showon="remote_storage:sftp"` attribute now works correctly. ## Test Plan - [ ] Edit profile → select SFTP → fields appear (host, port, username, password, key, passphrase, path) - [ ] Select FTP → FTP fields appear, SFTP fields hide - [ ] Select None → all remote fields hide
jmiller added 1 commit 2026-06-23 13:29:24 +00:00
fix: move SFTP fields into remote fieldset for showon to work
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / PHPStan Analysis (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Build RC Pre-Release (pull_request) Blocked by required conditions
Details
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Details
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Repository health (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Report Issues (pull_request) Blocked by required conditions
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 1s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 12s
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 4s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 7s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 5s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 6s
Details
Universal: Build & Release / Promote to RC (pull_request) Failing after 12s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Has been skipped
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 49s
Details
3ac0318ba3 
Joomla's showon JS only finds the controlling field (remote_storage)
within the same rendered fieldset/tab. SFTP fields were in a separate
fieldset so they were never shown. Moved into the remote fieldset
alongside the dropdown.
jmiller added 1 commit 2026-06-23 13:29:28 +00:00
chore(version): pre-release bump to 01.35.01-dev [skip ci]
Publish to Composer / Publish Package (release) Failing after 42s
Details
e465dfa6ee
jmiller added 1 commit 2026-06-23 13:32:31 +00:00
Merge remote-tracking branch 'origin/main' into fix/sftp-showon
Joomla: Extension CI / Tests (PHP 8.2) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Tests (PHP 8.3) (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / PHPStan Analysis (pull_request) Blocked by required conditions
Details
Joomla: Extension CI / Build RC Pre-Release (pull_request) Blocked by required conditions
Details
Universal: PR Check / Build RC Package (pull_request) Blocked by required conditions
Details
Universal: PR Check / Report Issues (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Repository health (pull_request) Blocked by required conditions
Details
Generic: Repo Health / Report Issues (pull_request) Blocked by required conditions
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 2s
Details
Joomla: Extension CI / Release Readiness Check (pull_request) Failing after 6s
Details
Generic: Repo Health / Access control (pull_request) Successful in 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 9s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 7s
Details
Joomla: Metadata Validation / Validate Joomla Metadata (pull_request) Successful in 14s
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 3s
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Failing after 7s
Details
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 24s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
Joomla: Extension CI / Lint & Validate (pull_request) Failing after 46s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Successful in 15s
Details
27dded6c62 
# Conflicts:
#	.mokogitea/workflows/issue-branch.yml
#	README.md
#	source/packages/com_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_actionlog_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_console_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_content_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_quickicon_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_system_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_task_mokosuitebackup/mokosuitebackup.xml
#	source/packages/plg_webservices_mokosuitebackup/mokosuitebackup.xml
#	source/pkg_mokosuitebackup.xml
jmiller merged commit 8be0500913 into main 2026-06-23 13:32:55 +00:00
jmiller deleted branch fix/sftp-showon 2026-06-23 13:32:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
component: admin
Admin UI and views
 component: api
REST API
 component: engine
Backup/restore engine
 component: remote
Remote storage (FTP/GDrive)
 component: scheduler
Scheduled tasks
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteBackup#95
Delete Branch "fix/sftp-showon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?