MokoConsulting/MokoSuiteCross
1
0
Fork 0
Code Issues 27 Pull Requests 1 Releases 5 Wiki Activity

bug: MokoSuiteCrossHelper::addSubmenu() has duplicate 'calendar' key #248

New Issue
Open
opened 2026-06-29 14:28:16 +00:00 by jmiller · 1 comment
jmiller commented 2026-06-29 14:28:16 +00:00
Owner
Copy Link
Copy Source

Problem

In src/Helper/MokoSuiteCrossHelper.php line 43-46, the $views array has a duplicate 'calendar' key:

$views = [
    'dashboard' => 'COM_MOKOSUITECROSS_SUBMENU_DASHBOARD',
    'posts'     => 'COM_MOKOSUITECROSS_SUBMENU_POSTS',
    'services'  => 'COM_MOKOSUITECROSS_SUBMENU_SERVICES',
    'templates' => 'COM_MOKOSUITECROSS_SUBMENU_TEMPLATES',
    'calendar'  => 'COM_MOKOSUITECROSS_SUBMENU_CALENDAR',   // line 43
    'logs'      => 'COM_MOKOSUITECROSS_SUBMENU_LOGS',
    'calendar'  => 'COM_MOKOSUITECROSS_SUBMENU_CALENDAR',   // line 45 -- DUPLICATE
    'analytics' => 'COM_MOKOSUITECROSS_SUBMENU_ANALYTICS',
];

PHP silently overwrites the first 'calendar' with the second. Both have the same value so there's no functional bug, but it means the submenu ordering is wrong -- calendar appears after logs instead of after templates.

Fix

Remove the duplicate line 45 entry. The correct order should be:
dashboard, posts, services, templates, calendar, analytics, logs

## Problem In `src/Helper/MokoSuiteCrossHelper.php` line 43-46, the `$views` array has a duplicate `'calendar'` key: ```php $views = [ 'dashboard' => 'COM_MOKOSUITECROSS_SUBMENU_DASHBOARD', 'posts' => 'COM_MOKOSUITECROSS_SUBMENU_POSTS', 'services' => 'COM_MOKOSUITECROSS_SUBMENU_SERVICES', 'templates' => 'COM_MOKOSUITECROSS_SUBMENU_TEMPLATES', 'calendar' => 'COM_MOKOSUITECROSS_SUBMENU_CALENDAR', // line 43 'logs' => 'COM_MOKOSUITECROSS_SUBMENU_LOGS', 'calendar' => 'COM_MOKOSUITECROSS_SUBMENU_CALENDAR', // line 45 -- DUPLICATE 'analytics' => 'COM_MOKOSUITECROSS_SUBMENU_ANALYTICS', ]; ``` PHP silently overwrites the first `'calendar'` with the second. Both have the same value so there's no functional bug, but it means the submenu ordering is wrong -- calendar appears after logs instead of after templates. ## Fix Remove the duplicate line 45 entry. The correct order should be: dashboard, posts, services, templates, calendar, analytics, logs
jmiller commented 2026-06-29 14:28:19 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/248-bug-mokosuitecrosshelper-addsubmenu-has-

git fetch origin
git checkout feature/248-bug-mokosuitecrosshelper-addsubmenu-has-
Branch created: [`feature/248-bug-mokosuitecrosshelper-addsubmenu-has-`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteCross/src/branch/feature/248-bug-mokosuitecrosshelper-addsubmenu-has-) ```bash git fetch origin git checkout feature/248-bug-mokosuitecrosshelper-addsubmenu-has- ```
Sign in to join this conversation.
Labels
No items
No labels
Priority Medium
Type Feature
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoSuiteCross#248
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?