fix(installer): gate install-success on real verification

Joomla installers keep running after a failed sub-step, so a postflight "installed successfully" / next-steps message can lie. Gate the success path in both installer scripts. Package (source/script.php): postflight now verifies every child extension declared in the package manifest actually registered in #__extensions (element + type, plus folder for plugins). If any are missing it enqueues an error listing them and returns before the licence notice. Download-key restore and plugin-enable housekeeping still run unconditionally. Check fails open on any error. Component (source/packages/com_mokoog/script.php): install() now parses the installed SQL (JPATH_ADMINISTRATOR/components/com_mokoog/sql/install.mysql.sql) for CREATE TABLE declarations and verifies each exists (prefix-substituted, case-insensitive) before echoing the success message. Fails open if the SQL is unreadable. Claude-Session: https://claude.ai/code/session_01MrxXW9iyuDda5yDZrjZMbF
2026-07-05 22:54:38 -05:00
parent 84b3d9dc2c
commit a6a24f72de
2 changed files with 155 additions and 1 deletions
@@ -50,9 +50,10 @@ class Pkg_MokoOGInstallerScript

 	public function postflight(string $type, InstallerAdapter $parent): void
 	{
+		// The download key must be restored regardless of the install outcome.
 		$this->restoreDownloadKey();
-		$this->warnMissingLicenseKey();

+		// Housekeeping: ensure the bundled plugins are enabled after a fresh install.
 		if ($type === 'install')
 		{
 			$db = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
@@ -69,6 +70,97 @@ class Pkg_MokoOGInstallerScript
 				)->execute();
 			}
 		}
+
+		// Be smart: only run the success path (the licence notice, which implies a
+		// completed install) when every child extension declared in the package
+		// manifest actually registered. If any are missing, the package did NOT
+		// install successfully — surface that instead of implying success.
+		$missing = $this->missingChildExtensions($parent);
+
+		if ($missing !== [])
+		{
+			Factory::getApplication()->enqueueMessage(
+				'<strong>MokoSuiteOpenGraph did not install completely.</strong> '
+				. 'The following extension(s) failed to install: ' . htmlspecialchars(implode(', ', $missing), ENT_QUOTES, 'UTF-8') . '. '
+				. 'Resolve the errors shown above, then uninstall and reinstall the package.',
+				'error'
+			);
+
+			return;
+		}
+
+		$this->warnMissingLicenseKey();
+	}
+
+	/**
+	 * Compare the child extensions the package manifest declares against what is
+	 * actually registered in #__extensions after the install/update. Returns the
+	 * label of each declared extension that is missing (i.e. failed to install);
+	 * an empty array means every child installed and the package succeeded.
+	 *
+	 * Fails open: any error returns [] so a query problem can never turn a good
+	 * install into a false "did not install completely" warning.
+	 *
+	 * @param   InstallerAdapter  $parent  Installer adapter
+	 *
+	 * @return  string[]
+	 */
+	private function missingChildExtensions(InstallerAdapter $parent): array
+	{
+		$missing = [];
+
+		try
+		{
+			$manifest = $parent->getParent()->getManifest();
+
+			if (!$manifest || !isset($manifest->files) || !isset($manifest->files->file))
+			{
+				return [];
+			}
+
+			$db = Factory::getContainer()->get(\Joomla\Database\DatabaseInterface::class);
+
+			foreach ($manifest->files->file as $file)
+			{
+				$childType = (string) $file['type'];
+				$element   = (string) $file['id'];
+				$group     = (string) $file['group'];
+
+				if ($element === '')
+				{
+					continue;
+				}
+
+				$query = $db->getQuery(true)
+					->select('COUNT(*)')
+					->from($db->quoteName('#__extensions'))
+					->where($db->quoteName('element') . ' = ' . $db->quote($element));
+
+				if ($childType !== '')
+				{
+					$query->where($db->quoteName('type') . ' = ' . $db->quote($childType));
+				}
+
+				// Plugins are only unique by element + folder (the manifest "group").
+				if ($childType === 'plugin' && $group !== '')
+				{
+					$query->where($db->quoteName('folder') . ' = ' . $db->quote($group));
+				}
+
+				$db->setQuery($query);
+
+				if ((int) $db->loadResult() === 0)
+				{
+					$missing[] = $element . ($group !== '' ? ' (' . $group . ')' : '');
+				}
+			}
+		}
+		catch (\Throwable $e)
+		{
+			return [];
+		}
+
+		return $missing;
 	}