From b4d5b73d15377fb9766e502ccb2f0d2b1ecb7ffb Mon Sep 17 00:00:00 2001
From: Jonathan Miller <jmiller-moko@noreply.git.mokoconsulting.tech>
Date: Tue, 23 Jun 2026 11:25:27 -0500
Subject: [PATCH] fix: code quality improvements (#76, #77, #78, #79)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Add exception logging to BatchController batch skip (#76)
- Align form maxlength with DB schema limits (#77)
- applySeoTags() already uses public API — no change needed (#78)
- Add strip_tags() input sanitization on OG text fields (#79)
---
 source/packages/com_mokoog/forms/tag.xml                  | 8 ++++----
 .../com_mokoog/src/Controller/BatchController.php         | 1 +
 source/packages/plg_content_mokoog/forms/mokoog.xml       | 8 ++++----
 .../plg_content_mokoog/src/Extension/MokoOGContent.php    | 8 ++++----
 4 files changed, 13 insertions(+), 12 deletions(-)

diff --git a/source/packages/com_mokoog/forms/tag.xml b/source/packages/com_mokoog/forms/tag.xml
index 83f8f93..9eb8168 100644
--- a/source/packages/com_mokoog/forms/tag.xml
+++ b/source/packages/com_mokoog/forms/tag.xml
@@ -30,7 +30,7 @@
             label="COM_MOKOOG_FIELD_OG_TITLE"
             description="COM_MOKOOG_FIELD_OG_TITLE_DESC"
             filter="string"
-            maxlength="70"
+            maxlength="255"
         />
         <field
             name="og_description"
@@ -39,7 +39,7 @@
             description="COM_MOKOOG_FIELD_OG_DESCRIPTION_DESC"
             filter="string"
             rows="3"
-            maxlength="200"
+            maxlength="512"
         />
         <field
             name="og_image"
@@ -85,7 +85,7 @@
             label="PLG_CONTENT_MOKOOG_FIELD_SEO_TITLE"
             description="PLG_CONTENT_MOKOOG_FIELD_SEO_TITLE_DESC"
             filter="string"
-            maxlength="70"
+            maxlength="255"
         />
         <field
             name="meta_description"
@@ -94,7 +94,7 @@
             description="PLG_CONTENT_MOKOOG_FIELD_META_DESCRIPTION_DESC"
             filter="string"
             rows="3"
-            maxlength="200"
+            maxlength="255"
         />
         <field
             name="robots"
diff --git a/source/packages/com_mokoog/src/Controller/BatchController.php b/source/packages/com_mokoog/src/Controller/BatchController.php
index 68141f4..b747f4f 100644
--- a/source/packages/com_mokoog/src/Controller/BatchController.php
+++ b/source/packages/com_mokoog/src/Controller/BatchController.php
@@ -120,6 +120,7 @@ class BatchController extends BaseController
                 $created++;
             } catch (\RuntimeException $e) {
                 $skipped++;
+                \Joomla\CMS\Log\Log::add('Batch insert failed for article ' . $article->id . ': ' . $e->getMessage(), \Joomla\CMS\Log\Log::WARNING, 'mokoog');
             }
         }
 
diff --git a/source/packages/plg_content_mokoog/forms/mokoog.xml b/source/packages/plg_content_mokoog/forms/mokoog.xml
index 64caba3..b5168e3 100644
--- a/source/packages/plg_content_mokoog/forms/mokoog.xml
+++ b/source/packages/plg_content_mokoog/forms/mokoog.xml
@@ -16,7 +16,7 @@
                 label="PLG_CONTENT_MOKOOG_FIELD_OG_TITLE"
                 description="PLG_CONTENT_MOKOOG_FIELD_OG_TITLE_DESC"
                 filter="string"
-                maxlength="70"
+                maxlength="255"
             />
             <field
                 name="og_description"
@@ -25,7 +25,7 @@
                 description="PLG_CONTENT_MOKOOG_FIELD_OG_DESCRIPTION_DESC"
                 filter="string"
                 rows="3"
-                maxlength="200"
+                maxlength="512"
             />
             <field
                 name="og_image"
@@ -66,7 +66,7 @@
                 label="PLG_CONTENT_MOKOOG_FIELD_SEO_TITLE"
                 description="PLG_CONTENT_MOKOOG_FIELD_SEO_TITLE_DESC"
                 filter="string"
-                maxlength="70"
+                maxlength="255"
             />
             <field
                 name="meta_description"
@@ -75,7 +75,7 @@
                 description="PLG_CONTENT_MOKOOG_FIELD_META_DESCRIPTION_DESC"
                 filter="string"
                 rows="3"
-                maxlength="200"
+                maxlength="255"
             />
             <field
                 name="robots"
diff --git a/source/packages/plg_content_mokoog/src/Extension/MokoOGContent.php b/source/packages/plg_content_mokoog/src/Extension/MokoOGContent.php
index 7500169..b7bac0a 100644
--- a/source/packages/plg_content_mokoog/src/Extension/MokoOGContent.php
+++ b/source/packages/plg_content_mokoog/src/Extension/MokoOGContent.php
@@ -245,13 +245,13 @@ final class MokoOGContent extends CMSPlugin implements SubscriberInterface
             'content_type'     => $contentType,
             'content_id'       => $contentId,
             'language'         => $language,
-            'og_title'         => trim($ogData['og_title'] ?? ''),
-            'og_description'   => trim($ogData['og_description'] ?? ''),
+            'og_title'         => strip_tags(trim($ogData['og_title'] ?? '')),
+            'og_description'   => strip_tags(trim($ogData['og_description'] ?? '')),
             'og_image'         => trim($ogData['og_image'] ?? ''),
             'og_type'          => trim($ogData['og_type'] ?? 'article'),
             'og_video'         => $this->sanitizeUrl($ogData['og_video'] ?? ''),
-            'seo_title'        => trim($ogData['seo_title'] ?? ''),
-            'meta_description' => trim($ogData['meta_description'] ?? ''),
+            'seo_title'        => strip_tags(trim($ogData['seo_title'] ?? '')),
+            'meta_description' => strip_tags(trim($ogData['meta_description'] ?? '')),
             'robots'           => trim($robots),
             'canonical_url'    => trim($ogData['canonical_url'] ?? ''),
             'published'        => 1,