Forward-compat: replace remaining deprecated Joomla APIs (Factory::getLanguage, Filesystem File/Folder) #102

New Issue

2026-06-29T14:19:46Z

jmiller commented

2026-06-29 14:19:46 +00:00

Problem

After the Joomla-7 forward-compat pass (PR #84, which handled getDbo/getUser/getSession/jexit), a few deprecated APIs remain. The extension targets Joomla 6+ and should be clean for 7.

Remaining deprecated usages

Factory::getLanguage() — deprecated since Joomla 4. Sites: plg_system_mokoog/src/Extension/MokoOG.php:142, 477, 497, 524. Replace with $this->getApplication()->getLanguage().
Joomla\CMS\Filesystem\File / Joomla\CMS\Filesystem\Folder — deprecated proxies. Sites: ImageHelper.php:15-16, ImageGenerator.php:15. Replace with Joomla\Filesystem\File / Joomla\Filesystem\Folder (or native equivalents).

Acceptance

No Factory::getLanguage() or Joomla\CMS\Filesystem\* usages in source/.
ci-joomla.yml deprecated-API check stays green.

## Problem After the Joomla-7 forward-compat pass (PR #84, which handled `getDbo`/`getUser`/`getSession`/`jexit`), a few deprecated APIs remain. The extension targets Joomla 6+ and should be clean for 7. ### Remaining deprecated usages - `Factory::getLanguage()` — deprecated since Joomla 4. Sites: `plg_system_mokoog/src/Extension/MokoOG.php:142, 477, 497, 524`. Replace with `$this->getApplication()->getLanguage()`. - `Joomla\CMS\Filesystem\File` / `Joomla\CMS\Filesystem\Folder` — deprecated proxies. Sites: `ImageHelper.php:15-16`, `ImageGenerator.php:15`. Replace with `Joomla\Filesystem\File` / `Joomla\Filesystem\Folder` (or native equivalents). ## Acceptance - No `Factory::getLanguage()` or `Joomla\CMS\Filesystem\*` usages in `source/`. - `ci-joomla.yml` deprecated-API check stays green.

jmiller added this to the Code Quality & Testing milestone 2026-06-29 14:19:46 +00:00

jmiller added the enhancement label 2026-06-29 14:19:46 +00:00

jmiller commented

2026-06-29 14:19:50 +00:00

Branch created: feature/102-forward-compat-replace-remaining-depreca

git fetch origin
git checkout feature/102-forward-compat-replace-remaining-depreca

Branch created: [`feature/102-forward-compat-replace-remaining-depreca`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteOpenGraph/src/branch/feature/102-forward-compat-replace-remaining-depreca) ```bash git fetch origin git checkout feature/102-forward-compat-replace-remaining-depreca ```

jmiller referenced this issue from a commit

2026-06-29 14:52:58 +00:00

fix: security & correctness batch (#99, #100, #101, #102, #106)

jmiller referenced this issue

2026-06-29 14:53:22 +00:00

fix: security & correctness batch — AI ACL, sitemap disclosure, API/CSV columns, forward-compat (#99 #100 #101 #102 #106) #109

jmiller referenced this issue from a commit

2026-06-29 14:53:44 +00:00

Merge pull request 'fix: security & correctness batch — AI ACL, sitemap disclosure, API/CSV columns, forward-compat (#99 #100 #101 #102 #106)' (#109) from fix/security-correctness-batch into dev

jmiller commented

2026-06-29 14:54:35 +00:00

Fixed in PR #109 (merged to dev). Replaced all four Factory::getLanguage() calls with getApplication()->getLanguage(), and swapped Joomla\CMS\Filesystem\File/Folder for Joomla\Filesystem\* in ImageHelper and ImageGenerator. Repo now has zero Factory::getLanguage() / Joomla\CMS\Filesystem usages. Closing.

Fixed in PR #109 (merged to `dev`). Replaced all four `Factory::getLanguage()` calls with `getApplication()->getLanguage()`, and swapped `Joomla\CMS\Filesystem\File/Folder` for `Joomla\Filesystem\*` in ImageHelper and ImageGenerator. Repo now has **zero** `Factory::getLanguage()` / `Joomla\CMS\Filesystem` usages. Closing.

jmiller closed this issue

2026-06-29 14:54:42 +00:00

jmiller referenced this issue

2026-06-29 16:00:44 +00:00

docs: CHANGELOG + README for the current development cycle #114

jmiller referenced this issue

2026-06-29 16:26:51 +00:00

Release: promote dev → main (dashboard, edit UI, ACL, security & forward-compat) #115

Sign in to join this conversation.