loadOgDataByType() and loadOgDataByMenu() ignore language on multilingual sites #47

New Issue

2026-06-21T14:54:12Z

jmiller commented

2026-06-21 14:54:12 +00:00

Problem

loadOgDataByType() (line 324) and loadOgDataByMenu() (line 346) in MokoOG.php query #__mokoog_tags without a language filter. The main loadOgData() method correctly filters by (language = $lang OR language = '*'), but these two helper methods do not.

Since the unique key is (content_type, content_id, language), multiple records can exist per content item. Without a language filter, loadObject() returns an arbitrary match.

Impact

On multilingual sites, category-level and menu-item-level OG fallback data may come from the wrong language.

Fix

Add the same language filter pattern used in loadOgData():

$lang = Factory::getLanguage()->getTag();
->where('(' . $db->quoteName('language') . ' = ' . $db->quote($lang)
    . ' OR ' . $db->quoteName('language') . ' = ' . $db->quote('*') . ')')

Files

source/packages/plg_system_mokoog/src/Extension/MokoOG.php:324-337
source/packages/plg_system_mokoog/src/Extension/MokoOG.php:346-358

## Problem `loadOgDataByType()` (line 324) and `loadOgDataByMenu()` (line 346) in `MokoOG.php` query `#__mokoog_tags` without a language filter. The main `loadOgData()` method correctly filters by `(language = $lang OR language = '*')`, but these two helper methods do not. Since the unique key is `(content_type, content_id, language)`, multiple records can exist per content item. Without a language filter, `loadObject()` returns an arbitrary match. ## Impact On multilingual sites, category-level and menu-item-level OG fallback data may come from the wrong language. ## Fix Add the same language filter pattern used in `loadOgData()`: ```php $lang = Factory::getLanguage()->getTag(); ->where('(' . $db->quoteName('language') . ' = ' . $db->quote($lang) . ' OR ' . $db->quoteName('language') . ' = ' . $db->quote('*') . ')') ``` ## Files - `source/packages/plg_system_mokoog/src/Extension/MokoOG.php:324-337` - `source/packages/plg_system_mokoog/src/Extension/MokoOG.php:346-358`

jmiller added the bug production-readiness labels 2026-06-21 14:54:12 +00:00

jmiller commented

2026-06-21 14:54:14 +00:00

Branch created: feature/47-loadogdatabytype-and-loadogdatabymenu-ig

git fetch origin
git checkout feature/47-loadogdatabytype-and-loadogdatabymenu-ig

Branch created: [`feature/47-loadogdatabytype-and-loadogdatabymenu-ig`](https://git.mokoconsulting.tech/MokoConsulting/MokoSuiteOpenGraph/src/branch/feature/47-loadogdatabytype-and-loadogdatabymenu-ig) ```bash git fetch origin git checkout feature/47-loadogdatabytype-and-loadogdatabymenu-ig ```

jmiller closed this issue

2026-06-21 16:14:25 +00:00

jmiller referenced this issue from a commit

2026-06-21 20:27:33 +00:00

fix: resolve 3 v1.0 release blockers (#47, #48, #39)

jmiller referenced this issue

2026-06-21 20:32:49 +00:00

v1.0 assessment: fix all blockers, add MokoSuiteShop, close 18 issues #54

Sign in to join this conversation.