MokoConsulting/Template-NPM

Template

Fork 0

(Refs #34) #37

Merged

jmiller merged 1 commits from fix/standardize-source-dir into dev

2026-07-18 18:22:31 +00:00

jmiller commented

2026-07-18 18:20:59 +00:00

Owner

git mv src -> source (history preserved), updates tsconfig.json, package.json, Makefile (SRC_DIR := source), and docs. Retires user-facing dist/ references (build output stays gitignored; releases go through the MokoGIT release system).

Note: the live metadata.entry_point -> source/ update is applied separately, timed with this merge.

Refs #34.

Review status

Two review passes run before this PR (code-reviewer + silent-failure-hunter); all Critical/High findings fixed in follow-up commits:

Composite action reads the token via inputs (not the inaccessible secrets context in composite actions).
Fail-closed source-dir resolver: metadata unreachable is distinguished from absent (strict callers hard-fail rather than silently defaulting); a genuine metadata↔Makefile conflict always errors.
Release: set -euo pipefail, non-empty artifact assertions, and gh release upload no longer error-suppressed.

Merge order

#33 (resolver) → #34 (source/ migration) → #35 (release) — #35 references the composite action introduced by #33.

Authored-by: Moko Consulting

`git mv src -> source` (history preserved), updates `tsconfig.json`, `package.json`, `Makefile` (`SRC_DIR := source`), and docs. Retires user-facing `dist/` references (build output stays gitignored; releases go through the MokoGIT release system). Note: the live `metadata.entry_point -> source/` update is applied separately, timed with this merge. Refs #34. ### Review status Two review passes run before this PR (code-reviewer + silent-failure-hunter); all Critical/High findings fixed in follow-up commits: - Composite action reads the token via `inputs` (not the inaccessible `secrets` context in composite actions). - **Fail-closed** source-dir resolver: metadata *unreachable* is distinguished from *absent* (strict callers hard-fail rather than silently defaulting); a genuine metadata↔Makefile conflict always errors. - Release: `set -euo pipefail`, non-empty artifact assertions, and `gh release upload` no longer error-suppressed. ### Merge order **#33 (resolver) → #34 (source/ migration) → #35 (release)** — #35 references the composite action introduced by #33. Authored-by: Moko Consulting

jmiller added 1 commit 2026-07-18 18:20:59 +00:00

refactor: migrate src/ to source/ and retire dist/ references [#34 ]

Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 22s

Details

Branch Policy Check / Verify merge target (pull_request) Successful in 2s

Details

Universal: PR Check / Branch Policy (pull_request) Successful in 3s

Details

Universal: PR Check / Secret Scan (pull_request) Successful in 7s

Details

Generic: Project CI / Lint & Validate (pull_request) Successful in 24s

Details

Universal: PR Check / Validate PR (pull_request) Successful in 7s

Details

Universal: Auto-Assign / Assign unassigned issues and PRs (pull_request_target) Successful in 3s

Details

Branch Cleanup / Delete merged branch (pull_request) Successful in 2s

Details

RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped

Details

Generic: Project CI / Tests (pull_request) Has been cancelled

Details

Universal: PR Check / Build RC Package (pull_request) Has been cancelled

Details

Universal: PR Check / Report Issues (pull_request) Has been cancelled

Details

8707d66108

Standardize the template on `source/` as the source input directory and
retire user-facing `src/` references, per issue #34.

Changes:
- git mv src -> source (history preserved for all .ts files)
- source/*.ts: update PATH headers /src/ -> /source/
- tsconfig.json: rootDir and include point at source/
- package.json: lint script targets source/
- Makefile: add SRC_DIR := source (CI resolver source of truth)
- README.md, CLAUDE.md, docs/ARCHITECTURE.md: source path refs -> source/

The `dist/` directory is retained solely as tsc's compiled build output
(outDir), which is already gitignored and never committed/published;
releases go through the MokoGIT release system. No new dist/ references
were introduced.

Authored-by: Moko Consulting

jmiller merged commit fd3d0d2055 into dev

2026-07-18 18:22:31 +00:00

jmiller deleted branch fix/standardize-source-dir

2026-07-18 18:22:34 +00:00

jmiller referenced this pull request

2026-07-18 18:24:02 +00:00

release: source-dir standardization + npm two-zip release (dev -> main) #39

jmiller referenced this pull request

2026-07-18 18:25:21 +00:00

standards: migrate src/ → source/ and retire dist/ (template + cascade) #34