12 Commits

Author	SHA1	Message	Date
Jonathan Miller	3e2e291819	fix: PHPStan level 5 → 6 — baseline 360 missing array generics ... Level 6 requires generic type annotations on all arrays. 357 of 360 errors are missingType.iterableValue (bare array without generics). Baselined — these are PHPDoc-only changes with no functional impact. PHPStan level 6: 0 errors with baseline. Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-25 22:47:39 -05:00
Jonathan Miller	cbb4d73df5	fix: PHPStan level 4 → 5 — fix 4 errors ... - bulk_sync: remove redundant array_values on already-list array - RepositorySynchronizer: fix metrics increment() — labels passed as 2nd param (value) instead of 3rd (labels), was a real bug PHPStan level 5: 0 errors. Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-25 22:42:50 -05:00
Jonathan Miller	e8da1a30ff	fix: PHPStan level 3 → 4 — remove dead code, baseline 41 items ... Removed 13 write-only properties and unused code. Remaining 41 baselined items are defensive patterns (null coalesce on API responses, boolean safety checks) that are intentional. PHPStan level 4: 0 errors with baseline. Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-25 22:31:25 -05:00
Jonathan Miller	05e4f39e7d	fix: PHPStan level 2 → 3 — fix 12 return type errors ... - Interface return types: narrowed list types to array<mixed> for API responses (ApiClient returns array<string, mixed>, not typed lists) - paginateAll(): wrap return with array_values() for numeric keys - listLabels: include id in return type - check_file_integrity: fix sftpConfig default value type Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-25 22:18:07 -05:00
Jonathan Miller	bc67a53442	chore: migrate 7 CLIApp scripts to CliFramework + remove PHPStan excludes ... All 7 legacy CLIApp scripts migrated to CliFramework: - validate/check_wiki_health.php - validate/auto_detect_platform.php - cli/joomla_release.php - automation/push_files.php - automation/bulk_sync.php - automation/bulk_joomla_template.php - automation/repo_cleanup.php Migration: extends CLIApp -> CliFramework, setupArguments() -> configure(), addOption() -> addArgument(), getOption() -> getArgument(), boot code updated. Also: removed PHPStan exclusions, fixed ApiClient::delete() signature, renamed conflicting log()/error() overrides. PHPStan level 2: 0 errors, 0 files excluded. Closes #101 Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-25 21:20:30 -05:00
Jonathan Miller	cbfa23c4c4	fix: PHPStan level 0 → 2 — fix 67 type errors across 18 files ... Real bugs found and fixed: - bulk_joomla_template: $org undefined in heredoc (missing parameter) - RepositorySynchronizer: $root undefined (should be $repoRoot), duplicate array key - RepositoryHealthChecker: wrong class name (UnifiedValidation → UnifiedValidator) - scan_drift: missing $adapter property declaration - auto_detect_platform: wrong method name (detectProjectType → detect) - EnterpriseReadinessValidator: void return used as value - check_client_theme: extra parameter to printSummary() - ApiClient: unused constructor parameter now stored - GitPlatformAdapter: added listBranches/getCloneUrl/cloneRepo to interface - MokoGiteaAdapter/GitHubAdapter: implemented new interface methods 3 legacy CLIApp scripts excluded (need migration to CliFramework): repo_cleanup.php, push_files.php, joomla_release.php Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-25 19:29:52 -05:00
Jonathan Miller	7bbd4853a8	fix(ci): make PHPStan advisory + rename MokoStandards to moko-platform ... - PHPStan: continue-on-error since 55 pre-existing errors at level 0 need to be fixed incrementally, not in a CI fix PR - Rename MokoStandards references to moko-platform in config files Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-24 22:48:01 -05:00
Jonathan Miller	2b48b09ffa	fix(ci): lower PHPStan to level 0 (173 pre-existing errors at level 5) ... Level 5 surfaced 173 type errors across the codebase that predate this PR. Start at level 0 to unblock CI, then raise incrementally as errors are addressed. Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-24 18:22:57 -05:00
Jonathan Miller	b1d4a979f8	fix(ci): remove deprecated PHPStan 1.x config options ... PHPStan 2.x removed checkMissingIterableValueType, checkGenericClassInNonGenericObjectType, checkAlwaysTrueCheckTypeFunctionCall, checkAlwaysTrueInstanceof, checkAlwaysTrueStrictComparison, and checkExplicitMixedMissingReturn — these are now always enabled at level 5+. Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-24 17:51:47 -05:00
Jonathan Miller	d64fea05bf	fix(ci): mark node_modules as optional in phpstan.neon ... PHPStan 2.x requires non-existent exclude paths to be marked with (?) to indicate they are optional. Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-24 17:46:15 -05:00
Jonathan Miller	f1f907bca0	fix(ci): repair repo-health and code quality gate failures ... - repo-health.yml: use .mokogitea/workflows/ instead of .gitea/workflows/ (moko-platform uses the mokogitea convention) - phpcs.xml/phpstan.neon: point to actual source dirs (lib/, validate/, automation/, cli/) instead of non-existent api/src and api/tests Authored-by: Moko Consulting Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-05-24 03:29:49 -05:00
Claude Code	5e63faf229	Initial: MokoStandards Enterprise API extracted from MokoStandards ... Standalone Composer package (mokoconsulting-tech/enterprise). Source: api/, bin/, lib/ directories from MokoStandards main repo. Autoload paths updated for standalone layout.	2026-04-13 06:12:04 +00:00