MokoConsulting/moko-platform
1
0
Fork 0
Code Issues 9 Pull Requests Actions 41 Packages Releases 4 Wiki Activity

fix(cli): Joomla module element detection and display name fixes #203

Merged
jmiller merged 4 commits from dev into main 2026-05-28 22:19:02 +00:00
Conversation 0 Commits 4 Files Changed 4
+28 -6
jmiller commented 2026-05-28 22:17:01 +00:00
Owner
Copy Link
Copy Source

Summary

  • Add module= attribute extraction to manifest_element.php and release_package.php
  • Fix element in updates.xml to include type prefix (mod_, com_, tpl_, lib_)
  • Prefer human-readable name from .mokogitea/manifest.xml for display names
  • Prevent display name doubling

Test plan

  • Run dev release on MokoJoomHero and verify updates.xml correctness
  • Verify ZIP filename is mod_mokojoomhero-VERSION.zip
## Summary - Add module= attribute extraction to manifest_element.php and release_package.php - Fix element in updates.xml to include type prefix (mod_, com_, tpl_, lib_) - Prefer human-readable name from .mokogitea/manifest.xml for display names - Prevent display name doubling ## Test plan - [ ] Run dev release on MokoJoomHero and verify updates.xml correctness - [ ] Verify ZIP filename is mod_mokojoomhero-VERSION.zip
jmiller added 4 commits 2026-05-28 22:17:01 +00:00
fix(cli): correct element prefix and display name in updates_xml_build
Platform: moko-platform CI / Gate 2: Unit Tests (8.1) (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.2) (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.3) (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 3: Self-Health Check (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 4: Governance (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 5: Template Integrity (push) Blocked by required conditions
Details
Platform: moko-platform CI / CI Summary (push) Blocked by required conditions
Details
Generic: Repo Health / Release configuration (push) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (push) Blocked by required conditions
Details
Generic: Repo Health / Repository health (push) Blocked by required conditions
Details
Generic: Repo Health / Site Health (push) Has been skipped
Details
Generic: Repo Health / Access control (push) Successful in 1s
Details
Universal: Auto Version Bump / Version Bump (push) Successful in 5s
Details
Platform: moko-platform CI / Gate 1: Code Quality (push) Failing after 1m2s
Details
d7e679b7b2 
- Add type prefix (mod_, com_, tpl_, lib_) to <element> in updates.xml
  so it matches Joomla's #__extensions table. Previously only packages
  got their prefix re-added after the strip on line 178.
- Prefer human-readable name from .mokogitea/manifest.xml <identity><name>
  when the Joomla manifest <name> is a technical prefixed name (mod_foo).
  Prevents display names like "Module - mod_mokojoomhero".
- Existing "Type - " prefix strip still prevents doubling when the
  language key already resolves to "Module - MokoJoomHero".

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chore(version): auto-bump patch 09.03.01-dev [skip ci] 32e34fc936
fix(cli): add module= attribute extraction to element detection
Platform: moko-platform CI / Gate 2: Unit Tests (8.1) (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.2) (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.3) (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 3: Self-Health Check (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 4: Governance (push) Blocked by required conditions
Details
Platform: moko-platform CI / Gate 5: Template Integrity (push) Blocked by required conditions
Details
Platform: moko-platform CI / CI Summary (push) Blocked by required conditions
Details
Generic: Repo Health / Release configuration (push) Blocked by required conditions
Details
Generic: Repo Health / Scripts governance (push) Blocked by required conditions
Details
Generic: Repo Health / Repository health (push) Blocked by required conditions
Details
Generic: Repo Health / Site Health (push) Has been skipped
Details
Generic: Repo Health / Access control (push) Successful in 1s
Details
Universal: Auto Version Bump / Version Bump (push) Successful in 4s
Details
Platform: moko-platform CI / Gate 1: Code Quality (push) Failing after 48s
Details
1cbdaa0c37 
Joomla modules declare their element via the module="mod_foo" attribute
on the entry <filename>, not via an <element> tag. Both manifest_element.php
and release_package.php were missing this extraction, causing incorrect
element names and ZIP filenames for module-type extensions.

Added module="..." regex check in the element detection chain for both
files, matching what updates_xml_build.php already had.

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
chore(version): auto-bump patch 09.03.02-dev [skip ci]
Branch Cleanup / Delete merged branch (pull_request) Has been skipped
Details
Universal: Build & Release / Promote Pre-Release to RC (pull_request) Has been skipped
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Failing after 13s
Details
048d1f4914
jmiller merged commit f2be11a5c3 into main 2026-05-28 22:19:02 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 priority: critical
Critical priority, must be addressed immediately
 priority: high
High priority
 priority: low
Low priority
 priority: medium
Medium priority
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 status: blocked
Blocked by another issue or dependency
 status: in-progress
Currently being worked on
 status: needs-review
Awaiting code review
 status: on-hold
Temporarily on hold
 status: pending
Pending action or decision
 status: wontfix
This will not be worked on
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 chore
Maintenance and housekeeping
 documentation
Documentation improvements
 enhancement
Improvement to existing functionality
 feature
New feature or request
 pending: dependency
Blocked by another issue or external dependency
 pending: deployment
Tested and approved, awaiting deployment to production
 pending: design
Needs UI/UX or architecture design before implementation
 pending: documentation
Feature works, needs documentation/wiki update
 pending: feedback
Awaiting feedback or decision from stakeholder
 pending: review
Implementation complete, awaiting code review
 pending: testing
Feature implemented but not yet tested
 priority: critical
Must fix immediately
 priority: high
Should fix soon
 priority: low
Nice to have
 priority: medium
Fix when convenient
 refactor
Code restructuring without behavior change
 roadmap
Planned feature or enhancement tracked on the roadmap
 scope: client
Client-specific work
 scope: dolibarr
Dolibarr modules and customizations
 scope: infrastructure
Server, CI, backups, monitoring
 scope: joomla
Joomla templates and extensions
 scope: waas
MokoWaaS platform
 security
Security vulnerability or hardening
 status: blocked
Waiting on external dependency
 status: duplicate
Duplicate of another issue
 status: in-progress
Being worked on
 status: needs-review
Ready for review
 status: wontfix
Will not be addressed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/moko-platform#203
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?