refactor: pre-release.yml should use existing CLI tools #163

New Issue

2026-05-26T17:51:33Z

jmiller commented

2026-05-26 17:51:33 +00:00

Problem

pre-release.yml duplicates logic that exists as CLI tools:

Platform detection via manual sed instead of manifest_read.php
Element detection (28 lines) instead of manifest_element.php
Inline php -r for updates.xml instead of updates_xml_build.php

Solution

Replace inline logic with CLI tool calls. Reduces pre-release.yml by ~65 lines and eliminates drift between workflows.

Files

pre-release.yml (update)

## Problem pre-release.yml duplicates logic that exists as CLI tools: 1. Platform detection via manual sed instead of manifest_read.php 2. Element detection (28 lines) instead of manifest_element.php 3. Inline php -r for updates.xml instead of updates_xml_build.php ## Solution Replace inline logic with CLI tool calls. Reduces pre-release.yml by ~65 lines and eliminates drift between workflows. ## Files - pre-release.yml (update)

jmiller added the ci-cd build labels 2026-05-26 17:51:33 +00:00

jmiller commented

2026-05-26 17:51:37 +00:00

Branch created: feature/163-refactor-pre-release-yml-should-use-exis

git fetch origin
git checkout feature/163-refactor-pre-release-yml-should-use-exis

Branch created: [`feature/163-refactor-pre-release-yml-should-use-exis`](https://git.mokoconsulting.tech/MokoConsulting/moko-platform/src/branch/feature/163-refactor-pre-release-yml-should-use-exis) ```bash git fetch origin git checkout feature/163-refactor-pre-release-yml-should-use-exis ```

jmiller commented

2026-05-26 19:45:52 +00:00

Proof

Commit 1dba0c3 on dev. Replaced 3 inline blocks with CLI tools:

Platform detection → manifest_read.php
Element detection (28 lines) → manifest_element.php (4 lines)
updates.xml inline PHP (25 lines) → updates_xml_build.php (3 lines)

Net: -85 lines, +14 lines = 71 lines removed

## Proof Commit 1dba0c3 on dev. Replaced 3 inline blocks with CLI tools: - Platform detection → manifest_read.php - Element detection (28 lines) → manifest_element.php (4 lines) - updates.xml inline PHP (25 lines) → updates_xml_build.php (3 lines) Net: -85 lines, +14 lines = **71 lines removed**

jmiller closed this issue

2026-05-26 19:45:52 +00:00

jmiller referenced this issue from a commit

2026-05-26 19:47:07 +00:00

refactor: pre-release.yml uses CLI tools instead of inline logic

jmiller referenced this issue from a commit

2026-05-26 20:12:14 +00:00

feat: CLI tools now read .mokogitea/manifest.xml for platform-aware behavior

Sign in to join this conversation.