MokoConsulting/mokoplatform
1
0
Fork 0
Code Issues 9 Pull Requests Releases 8 Wiki Activity

fix(cli): plugin commands listed but never dispatched in bin/moko #236

New Issue
Closed
opened 2026-05-31 14:20:39 +00:00 by jmiller · 2 comments
jmiller commented 2026-05-31 14:20:39 +00:00
Owner
Copy Link
Copy Source

Problem

bin/moko's loadPluginCommands() (lines 316-364) discovers plugin commands via getCommands() and displays them in the help listing, but never actually routes them for execution.

When a user runs a plugin-provided command, bin/moko returns "Unknown command" because only COMMAND_MAP entries are dispatched (line 200).

Related

  • #148 (feat: plugin CLI commands - populate getCommands())
  • Currently no plugins override getCommands() — they all return empty arrays

Proposal

  1. After COMMAND_MAP lookup fails, check plugin commands
  2. If a plugin command matches, resolve its script path and dispatch
  3. Pass plugin context (project type, config) to the dispatched script

Acceptance Criteria

  • Plugin-provided commands are executable via bin/moko
  • Plugin commands appear in php bin/moko list (already works)
  • Dispatch includes plugin type context
## Problem bin/moko's loadPluginCommands() (lines 316-364) discovers plugin commands via getCommands() and displays them in the help listing, but never actually routes them for execution. When a user runs a plugin-provided command, bin/moko returns "Unknown command" because only COMMAND_MAP entries are dispatched (line 200). ## Related - #148 (feat: plugin CLI commands - populate getCommands()) - Currently no plugins override getCommands() — they all return empty arrays ## Proposal 1. After COMMAND_MAP lookup fails, check plugin commands 2. If a plugin command matches, resolve its script path and dispatch 3. Pass plugin context (project type, config) to the dispatched script ## Acceptance Criteria - [ ] Plugin-provided commands are executable via bin/moko - [ ] Plugin commands appear in php bin/moko list (already works) - [ ] Dispatch includes plugin type context
jmiller added the build label 2026-05-31 14:20:39 +00:00
jmiller commented 2026-05-31 14:20:41 +00:00
Author
Owner
Copy Link
Copy Source

Branch created: feature/236-fix-cli-plugin-commands-listed-but-never

git fetch origin
git checkout feature/236-fix-cli-plugin-commands-listed-but-never
Branch created: [`feature/236-fix-cli-plugin-commands-listed-but-never`](https://git.mokoconsulting.tech/MokoConsulting/moko-platform/src/branch/feature/236-fix-cli-plugin-commands-listed-but-never) ```bash git fetch origin git checkout feature/236-fix-cli-plugin-commands-listed-but-never ```
jmiller commented 2026-05-31 15:16:07 +00:00
Author
Owner
Copy Link
Copy Source

Plugin command dispatch implemented in bin/moko. After COMMAND_MAP lookup fails, loadPluginCommands() is called as fallback. Plugin commands with a script field are now routable.

Plugin command dispatch implemented in `bin/moko`. After COMMAND_MAP lookup fails, `loadPluginCommands()` is called as fallback. Plugin commands with a `script` field are now routable.
Sign in to join this conversation.
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
No labels build
Priority High
Type Bug
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/mokoplatform#236
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?