MokoConsulting/mokoplatform
1
0
Fork 0
Code Issues 9 Pull Requests Releases 8 Wiki Activity

fix: PHPStan level 0 to 2 + 67 type errors fixed #93

Merged
jmiller merged 2 commits from dev into main 2026-05-26 00:32:29 +00:00
Conversation 0 Commits 2 Files Changed 22
+118 -42
jmiller commented 2026-05-26 00:32:21 +00:00
Owner
Copy Link
Copy Source

Summary

PHPStan bumped from level 0 to 2. Fixed 67 real type errors across 18 files including undefined variables, wrong class names, missing interface methods, and dead code.

3 legacy CLIApp scripts excluded pending migration.

## Summary PHPStan bumped from level 0 to 2. Fixed 67 real type errors across 18 files including undefined variables, wrong class names, missing interface methods, and dead code. 3 legacy CLIApp scripts excluded pending migration.
jmiller added 2 commits 2026-05-26 00:32:21 +00:00
Merge pull request 'chore: cascade main → dev (968f85f) [skip ci]' (#91) from main into dev e1104eeebc 
chore: cascade main → dev [skip ci]
fix: PHPStan level 0 → 2 — fix 67 type errors across 18 files
Generic: Repo Health / Site Health (push) Has been skipped
Details
Generic: Repo Health / Access control (push) Successful in 1s
Details
Generic: Repo Health / Scripts governance (push) Successful in 5s
Details
Generic: Repo Health / Release configuration (push) Successful in 5s
Details
Generic: Repo Health / Repository health (push) Successful in 12s
Details
Platform: moko-platform CI / Gate 1: Code Quality (push) Successful in 45s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: Secret Scanning / Gitleaks Secret Scan (pull_request) Successful in 4s
Details
Universal: PR Check / Validate PR (pull_request) Successful in 5s
Details
Universal: PR Check / Build RC Package (pull_request) Successful in 2s
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.2) (push) Failing after 44s
Details
Platform: moko-platform CI / Gate 3: Self-Health Check (push) Failing after 48s
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.1) (push) Failing after 48s
Details
Platform: moko-platform CI / Gate 4: Governance (push) Successful in 48s
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.3) (push) Failing after 50s
Details
Platform: moko-platform CI / Gate 5: Template Integrity (push) Failing after 12s
Details
Platform: moko-platform CI / Gate 1: Code Quality (pull_request) Successful in 1m13s
Details
Platform: moko-platform CI / Gate 5: Template Integrity (pull_request) Failing after 5s
Details
Platform: moko-platform CI / Gate 3: Self-Health Check (pull_request) Failing after 42s
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.2) (pull_request) Failing after 45s
Details
Platform: moko-platform CI / Gate 4: Governance (pull_request) Successful in 44s
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.1) (pull_request) Failing after 47s
Details
Platform: moko-platform CI / Gate 2: Unit Tests (8.3) (pull_request) Failing after 49s
Details
Platform: moko-platform CI / CI Summary (push) Has been cancelled
Details
Platform: moko-platform CI / CI Summary (pull_request) Has been cancelled
Details
cbfa23c4c4 
Real bugs found and fixed:
- bulk_joomla_template: $org undefined in heredoc (missing parameter)
- RepositorySynchronizer: $root undefined (should be $repoRoot), duplicate array key
- RepositoryHealthChecker: wrong class name (UnifiedValidation → UnifiedValidator)
- scan_drift: missing $adapter property declaration
- auto_detect_platform: wrong method name (detectProjectType → detect)
- EnterpriseReadinessValidator: void return used as value
- check_client_theme: extra parameter to printSummary()
- ApiClient: unused constructor parameter now stored
- GitPlatformAdapter: added listBranches/getCloneUrl/cloneRepo to interface
- MokoGiteaAdapter/GitHubAdapter: implemented new interface methods

3 legacy CLIApp scripts excluded (need migration to CliFramework):
  repo_cleanup.php, push_files.php, joomla_release.php

Authored-by: Moko Consulting
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jmiller merged commit 11bd5e8f7f into main 2026-05-26 00:32:29 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/mokoplatform#93
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?