MokoConsulting/MokoCLI
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests Packages Releases 8 Wiki Activity

fix: prevent duplicate version tags in Joomla manifests #322

Merged
jmiller merged 1 commits from fix/version-bump-duplicates into main 2026-06-27 00:48:18 +00:00
Conversation 0 Commits 1 Files Changed 3
+17 -5
jmiller commented 2026-06-27 00:43:21 +00:00
Owner
Copy Link
Copy Source

Summary

  • Use limit=1 in preg_replace for version tag replacement in all three version scripts
  • Add second pass to collapse any remaining duplicate <version> lines
  • Prevents CI from perpetuating duplicates introduced by merge conflicts or manual edits

Files changed

  • cli/version_bump.php — limit=1 + duplicate collapse for both prefix-aware and standard paths
  • cli/version_set_platform.php — limit=1 + duplicate collapse in Joomla section
  • cli/version_check.php — limit=1 + duplicate collapse in both manifest.xml and generic XML fix paths

Test plan

  • Run version_bump.php on a manifest with duplicate <version> tags — verify only one remains
  • Run version_set_platform.php on a manifest with duplicate tags — verify collapsed
  • Run version_check.php --fix on a repo with mismatched + duplicate versions — verify single tag with correct version
## Summary - Use `limit=1` in `preg_replace` for version tag replacement in all three version scripts - Add second pass to collapse any remaining duplicate `<version>` lines - Prevents CI from perpetuating duplicates introduced by merge conflicts or manual edits ## Files changed - `cli/version_bump.php` — limit=1 + duplicate collapse for both prefix-aware and standard paths - `cli/version_set_platform.php` — limit=1 + duplicate collapse in Joomla section - `cli/version_check.php` — limit=1 + duplicate collapse in both manifest.xml and generic XML fix paths ## Test plan - [ ] Run `version_bump.php` on a manifest with duplicate `<version>` tags — verify only one remains - [ ] Run `version_set_platform.php` on a manifest with duplicate tags — verify collapsed - [ ] Run `version_check.php --fix` on a repo with mismatched + duplicate versions — verify single tag with correct version
jmiller added 1 commit 2026-06-27 00:43:22 +00:00
fix: prevent duplicate <version> tags in Joomla manifests
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 9s
Details
Universal: PR Check / Branch Policy (pull_request) Failing after 2s
Details
Generic: Repo Health / Site Health (pull_request) Has been skipped
Details
Generic: Repo Health / Access control (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 4s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 6s
Details
Platform: mokocli CI / Gate 1: Code Quality (pull_request) Failing after 36s
Details
Universal: Build & Release / Promote to RC (pull_request) Has been skipped
Details
RC Revert / Rename rc/ back to dev/ (pull_request) Has been skipped
Details
Branch Cleanup / Delete merged branch (pull_request) Successful in 1s
Details
Universal: Build & Release / Build & Release Pipeline (pull_request) Successful in 15s
Details
Universal: Workflow Sync Trigger / Sync workflows to live repos (pull_request) Failing after 5m25s
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.1) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.2) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.3) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 3: Self-Health Check (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 4: Governance (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 5: Template Integrity (pull_request) Has been cancelled
Details
Platform: mokocli CI / CI Summary (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
Generic: Repo Health / Scripts governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Repository health (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Scripts Governance (pull_request) Has been cancelled
Details
Generic: Repo Health / Report: Repository Health (pull_request) Has been cancelled
Details
510d1248ab 
version_bump, version_set_platform, and version_check all used
unlimited preg_replace on <version> tags. If a duplicate ever got
introduced (merge conflict, manual edit), every subsequent CI bump
faithfully updated both copies — perpetuating the duplicate forever.

Fix: use limit=1 for the primary replacement, then collapse any
remaining duplicate <version> lines in a second pass.

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG
jmiller merged commit 84633e22e5 into main 2026-06-27 00:48:18 +00:00
jmiller deleted branch fix/version-bump-duplicates 2026-06-27 00:48:18 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#322
Delete Branch "fix/version-bump-duplicates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?