MokoConsulting/MokoCLI
Public Access
1
0
Fork 0
Code Issues 3 Pull Requests 1 Packages Releases 8 Wiki Activity

fix: auto-download pre-built release for empty submodule sub-packages #325

Open
jmiller wants to merge 1 commits from fix/submodule-release-download into dev
pull from: fix/submodule-release-download
merge into: :dev
Conversation 0 Commits 1 Files Changed 1
+115
jmiller commented 2026-06-28 19:35:24 +00:00
Owner
Copy Link
Copy Source

Summary

  • When a Joomla package has a sub-package that is a git submodule with an empty/missing source directory (e.g. failed CI checkout), the packager now falls back to downloading the latest stable release ZIP from the submodule's Gitea remote
  • Also supports pre-staged ZIPs in the output directory for manual/workflow pre-population
  • Fixes MokoSuiteBackup "Install path does not exist: MokoSuiteClient.zip" error caused by empty submodule during CI build

How it works

  1. Pre-built ZIP check: If a ZIP already exists in the output dir for a sub-package, use it directly (skip building from source)
  2. Submodule release download: If the source dir has no manifest XML (empty submodule), read .gitmodules to find the remote URL, derive the Gitea API path, and download the latest stable release asset
  3. Build from source: Original behavior as fallback

Test plan

  • Verify normal packaging (submodule present) still works as before
  • Test with empty submodule directory — should auto-download from Gitea release
  • Test with pre-staged ZIP in output directory — should use it directly
  • Verify MokoSuiteBackup release package includes valid MokoSuiteClient.zip (~4 MB)

https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG

## Summary - When a Joomla package has a sub-package that is a git submodule with an empty/missing source directory (e.g. failed CI checkout), the packager now falls back to downloading the latest stable release ZIP from the submodule's Gitea remote - Also supports pre-staged ZIPs in the output directory for manual/workflow pre-population - Fixes MokoSuiteBackup "Install path does not exist: MokoSuiteClient.zip" error caused by empty submodule during CI build ## How it works 1. **Pre-built ZIP check**: If a ZIP already exists in the output dir for a sub-package, use it directly (skip building from source) 2. **Submodule release download**: If the source dir has no manifest XML (empty submodule), read `.gitmodules` to find the remote URL, derive the Gitea API path, and download the latest `stable` release asset 3. **Build from source**: Original behavior as fallback ## Test plan - [ ] Verify normal packaging (submodule present) still works as before - [ ] Test with empty submodule directory — should auto-download from Gitea release - [ ] Test with pre-staged ZIP in output directory — should use it directly - [ ] Verify MokoSuiteBackup release package includes valid MokoSuiteClient.zip (~4 MB) https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG
jmiller added 1 commit 2026-06-28 19:35:25 +00:00
fix: auto-download pre-built release for empty submodule sub-packages
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 16s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 6s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 8s
Details
Platform: mokocli CI / Gate 1: Code Quality (pull_request) Failing after 48s
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.1) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.2) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.3) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 3: Self-Health Check (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 4: Governance (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 5: Template Integrity (pull_request) Has been cancelled
Details
Platform: mokocli CI / CI Summary (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
84259c6636 
When a Joomla package has a sub-package that is a git submodule with an
empty or missing source directory (e.g. failed CI checkout), the packager
now falls back to downloading the latest stable release ZIP from the
submodule's Gitea remote.

Also supports pre-staged ZIPs in the output directory, allowing manual
or workflow-based pre-population of sub-package archives.

Claude-Session: https://claude.ai/code/session_01MbEjBtsSjPuTWhqqrMS2wG
Some required checks failed
Universal: Pre-Release / Build Pre-Release (${{ inputs.stability || github.ref_name }}) (push) Successful in 16s
Details
Universal: PR Check / Branch Policy (pull_request) Successful in 1s
Details
Universal: PR Check / Validate PR (pull_request) Failing after 6s
Details
Universal: PR Check / Secret Scan (pull_request) Successful in 8s
Details
Platform: mokocli CI / Gate 1: Code Quality (pull_request) Failing after 48s
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.1) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.2) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 2: Unit Tests (8.3) (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 3: Self-Health Check (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 4: Governance (pull_request) Has been cancelled
Details
Platform: mokocli CI / Gate 5: Template Integrity (pull_request) Has been cancelled
Details
Platform: mokocli CI / CI Summary (pull_request) Has been cancelled
Details
Universal: PR Check / Build RC Package (pull_request) Has been cancelled
Details
Universal: PR Check / Report Issues (pull_request) Has been cancelled
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/submodule-release-download:fix/submodule-release-download
git checkout fix/submodule-release-download
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
automation
Automated processes or scripts
 breaking-change
Breaking API or functionality change
 build
Build system changes
 ci-cd
CI/CD pipeline changes
 config
Configuration file changes
 css
CSS/styling changes
 dependencies
Dependency updates
 deploy-failure
Automated deploy failure tracking
 docker
Docker configuration changes
 documentation
Documentation changes
 dolibarr
Dolibarr module or extension
 generic
Generic project or library
 good first issue
Good for newcomers
 health-check
Repository health check results
 health: excellent
Health score 90-100
 health: fair
Health score 50-69
 health: good
Health score 70-89
 health: poor
Health score below 50
 help wanted
Extra attention needed
 html
HTML template changes
 javascript
JavaScript code changes
 joomla
Joomla extension or component
 mokostandards
MokoStandards compliance
 needs-review
Awaiting code review
 php
PHP code changes
 push-failure
File push failure requiring attention
 python
Python code changes
 security
Security-related changes
 size/l
Large change (101-300 lines)
 size/m
Medium change (31-100 lines)
 size/s
Small change (11-30 lines)
 size/xl
Extra large change (301-1000 lines)
 size/xs
Extra small change (1-10 lines)
 size/xxl
Extremely large change (1000+ lines)
 standards-drift
Repository drifted from MokoStandards
 standards-update
MokoStandards sync update
 sync-failure
Bulk sync failure requiring attention
 sync-report
Bulk sync run report
 template-validation-failure
Template workflow validation failure
 tests
Test suite changes
 type: bug
Something isn't working
 type: chore
Maintenance tasks
 type: enhancement
Enhancement to existing feature
 type: feature
New feature or request
 type: refactor
Code refactoring
 type: version
Version-related change
 typescript
TypeScript code changes
 version
Version bump or release
 version-drift
Version mismatch detected
 work-in-progress
Work in progress, not ready for merge
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Priority -
Type -
Milestone
No items
No Milestone
Assignees
Clear assignees
jmiller (Jonathan Miller)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCLI#325
Delete Branch "fix/submodule-release-download"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?