Address final code review feedback
- Add setup notes to font CSS files about required downloads - Restore alert-warning class for font note (important setup info) - Fix alignment in success message border Co-authored-by: jmiller-moko <230051081+jmiller-moko@users.noreply.github.com>
This commit is contained in:
@@ -84,9 +84,9 @@ download_font "roboto" "https://fonts.googleapis.com/css2?family=Roboto:wght@100
|
||||
download_font "noto-sans" "https://fonts.googleapis.com/css2?family=Noto+Sans:wght@100;300;400;700&display=swap" "Noto Sans"
|
||||
download_font "fira-sans" "https://fonts.googleapis.com/css2?family=Fira+Sans:wght@100;300;400;700&display=swap" "Fira Sans"
|
||||
|
||||
echo -e "${GREEN}╔═══════════════════════════════════════════╗${NC}"
|
||||
echo -e "${GREEN}╔════════════════════════════════════════════╗${NC}"
|
||||
echo -e "${GREEN}║ ✓ All fonts downloaded successfully! ║${NC}"
|
||||
echo -e "${GREEN}╚═══════════════════════════════════════════╝${NC}"
|
||||
echo -e "${GREEN}╚════════════════════════════════════════════╝${NC}"
|
||||
echo ""
|
||||
echo -e "Font files saved to: ${BLUE}$(pwd)${NC}"
|
||||
echo ""
|
||||
|
||||
@@ -13,6 +13,20 @@
|
||||
BRIEF: Fira Sans font family definitions (self-hosted)
|
||||
*/
|
||||
|
||||
/*
|
||||
* IMPORTANT: Font files must be downloaded separately
|
||||
*
|
||||
* This CSS file references Fira Sans font files that must be manually downloaded
|
||||
* and placed in the fonts directory. See GOOGLE_FONTS_README.md in the fonts
|
||||
* directory for download instructions.
|
||||
*
|
||||
* Required files:
|
||||
* - fira-sans-v17-latin-100.woff2
|
||||
* - fira-sans-v17-latin-300.woff2
|
||||
* - fira-sans-v17-latin-regular.woff2
|
||||
* - fira-sans-v17-latin-700.woff2
|
||||
*/
|
||||
|
||||
/* Fira Sans Thin (100) */
|
||||
@font-face {
|
||||
font-family: 'Fira Sans';
|
||||
|
||||
@@ -13,6 +13,20 @@
|
||||
BRIEF: Noto Sans font family definitions (self-hosted)
|
||||
*/
|
||||
|
||||
/*
|
||||
* IMPORTANT: Font files must be downloaded separately
|
||||
*
|
||||
* This CSS file references Noto Sans font files that must be manually downloaded
|
||||
* and placed in the fonts directory. See GOOGLE_FONTS_README.md in the fonts
|
||||
* directory for download instructions.
|
||||
*
|
||||
* Required files:
|
||||
* - noto-sans-v36-latin-100.woff2
|
||||
* - noto-sans-v36-latin-300.woff2
|
||||
* - noto-sans-v36-latin-regular.woff2
|
||||
* - noto-sans-v36-latin-700.woff2
|
||||
*/
|
||||
|
||||
/* Noto Sans Thin (100) */
|
||||
@font-face {
|
||||
font-family: 'Noto Sans';
|
||||
|
||||
@@ -13,6 +13,20 @@
|
||||
BRIEF: Roboto font family definitions (self-hosted)
|
||||
*/
|
||||
|
||||
/*
|
||||
* IMPORTANT: Font files must be downloaded separately
|
||||
*
|
||||
* This CSS file references Roboto font files that must be manually downloaded
|
||||
* and placed in the fonts directory. See GOOGLE_FONTS_README.md in the fonts
|
||||
* directory for download instructions.
|
||||
*
|
||||
* Required files:
|
||||
* - roboto-v30-latin-100.woff2
|
||||
* - roboto-v30-latin-300.woff2
|
||||
* - roboto-v30-latin-regular.woff2
|
||||
* - roboto-v30-latin-700.woff2
|
||||
*/
|
||||
|
||||
/* Roboto Thin (100) */
|
||||
@font-face {
|
||||
font-family: 'Roboto';
|
||||
|
||||
@@ -206,7 +206,7 @@
|
||||
<option value="media/templates/site/mokocassiopeia/css/fonts/fira-sans.css">Fira Sans (local)</option>
|
||||
</group>
|
||||
</field>
|
||||
<field name="noteFontScheme" type="note" description="TPL_MOKOCASSIOPEIA_FONT_NOTE_TEXT" class="alert alert-info" />
|
||||
<field name="noteFontScheme" type="note" description="TPL_MOKOCASSIOPEIA_FONT_NOTE_TEXT" class="alert alert-warning" />
|
||||
|
||||
<!-- Branding & Icons -->
|
||||
<field name="theme_sep_brand" type="spacer" label="Branding & Icons" hr="false" class="text fw-bold" />
|
||||
|
||||
Reference in New Issue
Block a user