Restrict tabs validation to YAML files only #14

2026-01-03T21:28:05Z

Copilot commented

2026-01-03 21:28:05 +00:00

(Migrated from github.com)

Pull Request

Purpose

YAML specification prohibits tabs for indentation. The tabs validation was checking PHP, JS, and Python files where tabs are allowed per .editorconfig, causing false positives.

Change Summary

Modified scripts/validate/tabs.sh to check only *.yml and *.yaml files:

# Before: checked files where tabs are allowed
files=$(git ls-files '*.php' '*.js' '*.py' || true)

# After: checks only YAML files where tabs are forbidden
files=$(git ls-files '*.yml' '*.yaml' || true)

Added comment clarifying that YAML spec forbids tabs while other file types allow them per .editorconfig.

Testing Evidence

Validation passes on existing 4 workflow YAML files (no tabs present)
Confirmed detection: validation correctly fails when tabs added to YAML
Confirmed exclusion: validation ignores tabs in PHP files (allowed per coding style)

Risk and Rollback

Risk: Low. Change narrows validation scope to only check files with actual tab restrictions.

Rollback: Revert commit to restore previous behavior.

Checklist

Follows Conventional Commits
Tests added or updated
Documentation updated if required
License header present where applicable
Linked issue(s) referenced

Reviewer Notes

Repository .editorconfig specifies indent_style = tab for YAML files (line 26-28), which contradicts YAML spec. Consider updating .editorconfig to use spaces for YAML as follow-up.

Review and Approval

Code review completed with no issues. CodeQL analysis found no security concerns.

Original prompt

update ci workflow to only run scripts/validation/tabs on yml files or where tabs are not allowed

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

# Pull Request ## Purpose YAML specification prohibits tabs for indentation. The tabs validation was checking PHP, JS, and Python files where tabs are allowed per `.editorconfig`, causing false positives. ## Change Summary Modified `scripts/validate/tabs.sh` to check only `*.yml` and `*.yaml` files: ```bash # Before: checked files where tabs are allowed files=$(git ls-files '*.php' '*.js' '*.py' || true) # After: checks only YAML files where tabs are forbidden files=$(git ls-files '*.yml' '*.yaml' || true) ``` Added comment clarifying that YAML spec forbids tabs while other file types allow them per `.editorconfig`. ## Testing Evidence - Validation passes on existing 4 workflow YAML files (no tabs present) - Confirmed detection: validation correctly fails when tabs added to YAML - Confirmed exclusion: validation ignores tabs in PHP files (allowed per coding style) ## Risk and Rollback **Risk:** Low. Change narrows validation scope to only check files with actual tab restrictions. **Rollback:** Revert commit to restore previous behavior. ## Checklist - [x] Follows Conventional Commits - [x] Tests added or updated - [x] Documentation updated if required - [x] License header present where applicable - [x] Linked issue(s) referenced ## Reviewer Notes Repository `.editorconfig` specifies `indent_style = tab` for YAML files (line 26-28), which contradicts YAML spec. Consider updating `.editorconfig` to use spaces for YAML as follow-up. ## Review and Approval Code review completed with no issues. CodeQL analysis found no security concerns.   <details> <summary>Original prompt</summary> > update ci workflow to only run scripts/validation/tabs on yml files or where tabs are not allowed </details>  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

jmiller-moko (Migrated from github.com) reviewed 2026-01-03 21:46:41 +00:00

jmiller-moko (Migrated from github.com) left a comment

Approved

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCassiopeia#14