Fix GitHub Actions environment variable references in release pipeline #24

Merged
Copilot merged 2 commits from copilot/review-release-pipeline-workflow into main 2026-01-03 22:59:33 +00:00
Copilot commented 2026-01-03 22:46:54 +00:00 (Migrated from github.com)

Pull Request

Purpose

Bash was interpreting ${GITHUB_run/ID} as string substitution (remove "ID" from variable value) instead of environment variable access. Workflow would fail or produce malformed telemetry.

Change Summary

Corrected 9 variable references in .github/workflows/release_pipeline.yml:

  • GITHUB_run/IDGITHUB_RUN_ID
  • GITHUB_run/NUMBERGITHUB_RUN_NUMBER
  • GITHUB_run/ATTEMPTGITHUB_RUN_ATTEMPT

Affected sections:

  • Guard report JSON output (lines 172-175)
  • Run context JSON output (lines 205-208)
  • Build report JSON output (line 670)

Testing Evidence

  • YAML syntax validated
  • Bash string substitution behavior confirmed with test script
  • Code review: no issues
  • CodeQL: no vulnerabilities

Risk and Rollback

Risk: Minimal. Changes only affect JSON telemetry output in workflow summaries.

Rollback: Revert commit restores previous (broken) behavior.

Checklist

  • Follows Conventional Commits
  • Tests added or updated (N/A - workflow validation)
  • Documentation updated if required (N/A)
  • License header present where applicable (N/A)
  • Linked issue(s) referenced

Reviewer Notes

The syntax ${var/pattern} is bash parameter expansion for pattern substitution. Variables must match exact GitHub Actions names: GITHUB_RUN_ID, not GITHUB_run/ID.

Review and Approval

Original prompt

REVIEW Release Pipeline WORKFLOW AND MAKE FUNCTIONAL CHANGES TO MAKE THE CODE WORK


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

# Pull Request ## Purpose Bash was interpreting `${GITHUB_run/ID}` as string substitution (remove "ID" from variable value) instead of environment variable access. Workflow would fail or produce malformed telemetry. ## Change Summary Corrected 9 variable references in `.github/workflows/release_pipeline.yml`: - `GITHUB_run/ID` → `GITHUB_RUN_ID` - `GITHUB_run/NUMBER` → `GITHUB_RUN_NUMBER` - `GITHUB_run/ATTEMPT` → `GITHUB_RUN_ATTEMPT` Affected sections: - Guard report JSON output (lines 172-175) - Run context JSON output (lines 205-208) - Build report JSON output (line 670) ## Testing Evidence - YAML syntax validated - Bash string substitution behavior confirmed with test script - Code review: no issues - CodeQL: no vulnerabilities ## Risk and Rollback **Risk**: Minimal. Changes only affect JSON telemetry output in workflow summaries. **Rollback**: Revert commit restores previous (broken) behavior. ## Checklist - [x] Follows Conventional Commits - [x] Tests added or updated (N/A - workflow validation) - [x] Documentation updated if required (N/A) - [x] License header present where applicable (N/A) - [x] Linked issue(s) referenced ## Reviewer Notes The syntax `${var/pattern}` is bash parameter expansion for pattern substitution. Variables must match exact GitHub Actions names: `GITHUB_RUN_ID`, not `GITHUB_run/ID`. ## Review and Approval <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > REVIEW Release Pipeline WORKFLOW AND MAKE FUNCTIONAL CHANGES TO MAKE THE CODE WORK </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.
jmiller-moko (Migrated from github.com) approved these changes 2026-01-03 22:57:30 +00:00
jmiller-moko (Migrated from github.com) left a comment

Approved

Approved
Sign in to join this conversation.
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: MokoConsulting/MokoCassiopeia#24