MokoConsulting/MokoCassiopeia
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Releases 1 Activity

Fix revision history tables in documentation and resolve CI workflow errors #35

Merged
Copilot merged 8 commits from copilot/fix-readme-revision-history into main 2026-01-06 08:09:58 +00:00
Conversation 12 Commits 8 Files Changed 3 -8
2 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e1dcc80e60 - Show all commits

2
.github/workflows/joomla_testing.yml vendored
View File

@@ -239,8 +239,6 @@ jobs:
key: ${{ runner.os }}-composer-codeception-8.1-${{ hashFiles('**/composer.lock') }} key: ${{ runner.os }}-composer-codeception-8.1-${{ hashFiles('**/composer.lock') }}
restore-keys: | restore-keys: |
${{ runner.os }}-composer-codeception-8.1- ${{ runner.os }}-composer-codeception-8.1-
${{ runner.os }}-composer-codeception-
${{ runner.os }}-composer-
- name: Install Codeception - name: Install Codeception
env: env:

6
.github/workflows/php_quality.yml vendored
View File

@@ -45,8 +45,6 @@ jobs:
key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }} key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
copilot-pull-request-reviewer[bot] commented 2026-01-06 08:14:46 +00:00 (Migrated from github.com)
Review
Copy Link

The cache key uses hashFiles('**/composer.lock') but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key.

          key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-global-v1
The cache key uses `hashFiles('**/composer.lock')` but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively `${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-`, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key. ```suggestion key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-global-v1 ```
restore-keys: | restore-keys: |
${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}- ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-
${{ runner.os }}-composer-phpcs-
${{ runner.os }}-composer-
- name: Install PHP_CodeSniffer - name: Install PHP_CodeSniffer
env: env:
@@ -101,8 +99,6 @@ jobs:
key: ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }} key: ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
restore-keys: | restore-keys: |
${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}- ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-
${{ runner.os }}-composer-phpstan-
${{ runner.os }}-composer-
- name: Install PHPStan - name: Install PHPStan
env: env:
@@ -151,8 +147,6 @@ jobs:
key: ${{ runner.os }}-composer-phpcompat-8.3-${{ hashFiles('**/composer.lock') }} key: ${{ runner.os }}-composer-phpcompat-8.3-${{ hashFiles('**/composer.lock') }}
restore-keys: | restore-keys: |
${{ runner.os }}-composer-phpcompat-8.3- ${{ runner.os }}-composer-phpcompat-8.3-
${{ runner.os }}-composer-phpcompat-
${{ runner.os }}-composer-
- name: Install dependencies - name: Install dependencies
env: env: