MokoConsulting/MokoCassiopeia
1
1
Fork 0
Code Issues 4 Pull Requests Actions Packages Releases 1 Activity

Fix revision history tables in documentation and resolve CI workflow errors #35

Merged
Copilot merged 8 commits from copilot/fix-readme-revision-history into main 2026-01-06 08:09:58 +00:00
Conversation 12 Commits 8 Files Changed 3 +13 -13
3 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/joomla_testing.yml vendored
View File

@@ -56,8 +56,6 @@ jobs:
uses: actions/setup-node@v4
with:
node-version: '18'
cache: 'npm'
cache-dependency-path: '**/package-lock.json'
- name: Cache Joomla Downloads
uses: actions/cache@v4
@@ -241,10 +239,10 @@ jobs:
key: ${{ runner.os }}-composer-codeception-8.1-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-codeception-8.1-
${{ runner.os }}-composer-codeception-
${{ runner.os }}-composer-
- name: Install Codeception
env:
COMPOSER_AUTH: '{"github-oauth": {"github.com": "${{ secrets.GITHUB_TOKEN }}"}}'
run: |
composer global require codeception/codeception
composer global require codeception/module-db
copilot-pull-request-reviewer[bot] commented 2026-01-06 08:14:46 +00:00 (Migrated from github.com)
Review
Copy Link

The cache key uses hashFiles('**/composer.lock') but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively ${{ runner.os }}-composer-codeception-8.1-, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key.

          key: ${{ runner.os }}-composer-codeception-8.1-global
The cache key uses `hashFiles('**/composer.lock')` but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively `${{ runner.os }}-composer-codeception-8.1-`, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key. ```suggestion key: ${{ runner.os }}-composer-codeception-8.1-global ```

13
.github/workflows/php_quality.yml vendored
View File

@@ -45,10 +45,10 @@ jobs:
key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
copilot-pull-request-reviewer[bot] commented 2026-01-06 08:14:46 +00:00 (Migrated from github.com)
Review
Copy Link

The cache key uses hashFiles('**/composer.lock') but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key.

          key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-global-v1
The cache key uses `hashFiles('**/composer.lock')` but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively `${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-`, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key. ```suggestion key: ${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-global-v1 ```
restore-keys: |
${{ runner.os }}-composer-phpcs-${{ matrix.php-version }}-
${{ runner.os }}-composer-phpcs-
${{ runner.os }}-composer-
- name: Install PHP_CodeSniffer
env:
COMPOSER_AUTH: '{"github-oauth": {"github.com": "${{ secrets.GITHUB_TOKEN }}"}}'
run: |
composer global require "squizlabs/php_codesniffer:^3.0" --with-all-dependencies
composer global require "phpcompatibility/php-compatibility:^9.0" --with-all-dependencies
@@ -99,11 +99,12 @@ jobs:
key: ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-
${{ runner.os }}-composer-phpstan-
${{ runner.os }}-composer-
- name: Install PHPStan
env:
COMPOSER_AUTH: '{"github-oauth": {"github.com": "${{ secrets.GITHUB_TOKEN }}"}}'
run: |
composer global config --no-plugins allow-plugins.phpstan/extension-installer true
composer global require phpstan/phpstan "^1.0" --with-all-dependencies
composer global require phpstan/extension-installer "^1.0" --with-all-dependencies
@@ -146,10 +147,10 @@ jobs:
key: ${{ runner.os }}-composer-phpcompat-8.3-${{ hashFiles('**/composer.lock') }}
restore-keys: |
${{ runner.os }}-composer-phpcompat-8.3-
${{ runner.os }}-composer-phpcompat-
${{ runner.os }}-composer-
- name: Install dependencies
env:
COMPOSER_AUTH: '{"github-oauth": {"github.com": "${{ secrets.GITHUB_TOKEN }}"}}'
run: |
composer global require "squizlabs/php_codesniffer:^3.0" --with-all-dependencies
composer global require "phpcompatibility/php-compatibility:^9.0" --with-all-dependencies

7
README.md
View File

@@ -207,6 +207,7 @@ See the [CHANGELOG.md](./CHANGELOG.md) for detailed version history.
## Revision History
| Version | Date | Author | Description |
| ------- | ---------- | -----------------------------_-- | ------------------------------------- |
| 3.0 | 2025-12-09 | Jonathan Miller (@jmiller-moko) | Added Metadata and Revision History |
| Date | Change Summary | Author |
| ---------- | ------------------------------------------------------------------- | ------------------------------- |
| 2026-01-05 | Initial publication of template documentation and feature overview. | Moko Consulting |
| 2026-01-05 | Fixed malformed markdown table formatting in revision history. | Jonathan Miller (@jmiller-moko) |