MokoConsulting/MokoCassiopeia
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Releases 1 Activity

Fix revision history tables in documentation and resolve CI workflow errors #35

Merged
Copilot merged 8 commits from copilot/fix-readme-revision-history into main 2026-01-06 08:09:58 +00:00
Conversation 12 Commits 8 Files Changed 3 +1
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f67946f0c0 - Show all commits

1
.github/workflows/php_quality.yml vendored
View File

@@ -108,6 +108,7 @@ jobs:
env:
COMPOSER_AUTH: '{"github-oauth": {"github.com": "${{ secrets.GITHUB_TOKEN }}"}}'
run: |
composer global config --no-plugins allow-plugins.phpstan/extension-installer true
composer global require phpstan/phpstan "^1.0" --with-all-dependencies
copilot-pull-request-reviewer[bot] commented 2026-01-06 08:14:45 +00:00 (Migrated from github.com)
Review
Copy Link

The cache key uses hashFiles('**/composer.lock') but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key.

          key: ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}
The cache key uses `hashFiles('**/composer.lock')` but there is no composer.lock file in this repository. This means the hash will always return an empty string, making the cache key effectively `${{ runner.os }}-composer-phpstan-${{ matrix.php-version }}-`, which is the same as the restore-key. This doesn't break functionality but makes the cache key less specific than intended. Since this is a global composer installation (not project-specific), consider either removing the hashFiles part or using a static cache key. ```suggestion key: ${{ runner.os }}-composer-phpstan-${{ matrix.php-version }} ```
composer global require phpstan/extension-installer "^1.0" --with-all-dependencies